This repository was archived by the owner on May 12, 2023. It is now read-only.
Ozon uk homework 3 #79
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 11, 2021 11:37
…added, viewsets for stock and price added to views
…r restframework done, pagination added
VeliAliyev
approved these changes
Dec 11, 2021
|
|
||
| from baskets.models import Basket, BasketItem | ||
|
|
||
| #Basket Filter |
There was a problem hiding this comment.
Bence bu ve bunun gibi comment'ler kaldirilabilir cunku class isminden anlayabilecegimizden baska extra bir bilgi vermiyor.
eibrahimarisoy
left a comment
eibrahimarisoy
left a comment
There was a problem hiding this comment.
DetailedSerializer tanımlamalarını kalıtım yoluyla oluştururken fieldsda tanınımlı olmayan alanları eklemişsin.
Bu alanları tekrar fieldsa eklemen gerekli.
The field 'products' was declared on serializer PriceDetailedSerializer, but has not been included in the 'fields' option.
böyle bir hata alırsın.
|
|
||
| # Basket Detailed Serializer - nested serializer | ||
| class BasketDetailedSerializer(BasketSerializer): | ||
| customers = CustomerSerializer() |
There was a problem hiding this comment.
customers yanlış olmuş customer olmalı
upy
suggested changes
Dec 12, 2021
|
|
||
| # Stock Detailed Serializer - nested serializer | ||
| class StockDetailedSerializer(StockSerializer): | ||
| products = ProductSerializer() |
Owner
There was a problem hiding this comment.
products seklinde bir fieldimiz yok sanki?
|
|
||
| # Price Detailed Serializer - nested serializer | ||
| class PriceDetailedSerializer(PriceSerializer): | ||
| products = ProductSerializer() |
Owner
There was a problem hiding this comment.
products seklinde bir fieldimiz yok sanki?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To have REST API for our project, necessary serializers and viewsets added to the following apps
Router registrations for URLs made
README.md updated