Skip to content

Optimising linter and add API test coverage #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
flovntp merged 2 commits into from
Nov 20, 2025
Merged

Optimising linter and add API test coverage #86

flovntp merged 2 commits into from
Nov 20, 2025

Conversation

@flovntp
Copy link
Contributor

@flovntp flovntp commented Nov 19, 2025

  • optimise linter by reporting updates in mustache templates
  • add Apis vs Facades coverage
  • optimise PHP Unit constructor

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@platformsh-devrel
Copy link
Collaborator

platformsh-devrel commented Nov 19, 2025 •
edited
Loading

🧾 API Coverage Report

Last updated: b9b5d76 • Run #122

Metric Value
Total API methods 235
Called from facades 195
Unmapped API methods 40
Invalid Facade API calls 0
Coverage 82.98%
📋 Full JSON report 
{
  "total_api_methods": 235,
  "called_methods": 195,
  "unmapped_methods": [
    "Upsun\\Api\\SshKeysApi::createSshKey",
    "Upsun\\Api\\SshKeysApi::deleteSshKey",
    "Upsun\\Api\\SshKeysApi::getSshKey",
    "Upsun\\Api\\AutoscalingApi::getAutoscalerSettings",
    "Upsun\\Api\\AutoscalingApi::patchAutoscalerSettings",
    "Upsun\\Api\\AutoscalingApi::postAutoscalerSettings",
    "Upsun\\Api\\CertificateProvisionerApi::getProjectsProvisioners",
    "Upsun\\Api\\CertificateProvisionerApi::listProjectsProvisioners",
    "Upsun\\Api\\CertificateProvisionerApi::updateProjectsProvisioners",
    "Upsun\\Api\\EnvironmentApi::deployEnvironment",
    "Upsun\\Api\\ReferencesApi::listReferencedOrgs",
    "Upsun\\Api\\ReferencesApi::listReferencedProjects",
    "Upsun\\Api\\ReferencesApi::listReferencedRegions",
    "Upsun\\Api\\ReferencesApi::listReferencedTeams",
    "Upsun\\Api\\ReferencesApi::listReferencedUsers",
    "Upsun\\Api\\ProjectApi::actionProjectsClearBuildCache",
    "Upsun\\Api\\UserProfilesApi::createProfilePicture",
    "Upsun\\Api\\SubscriptionsApi::canUpdateSubscription",
    "Upsun\\Api\\SubscriptionsApi::getOrgSubscription",
    "Upsun\\Api\\SubscriptionsApi::getSubscriptionUsageAlerts",
    "Upsun\\Api\\SubscriptionsApi::listOrgSubscriptions",
    "Upsun\\Api\\SubscriptionsApi::listSubscriptionAddons",
    "Upsun\\Api\\SubscriptionsApi::updateOrgSubscription",
    "Upsun\\Api\\SubscriptionsApi::updateSubscriptionUsageAlerts",
    "Upsun\\Api\\OrganizationProjectsApi::createOrgProject",
    "Upsun\\Api\\OrganizationProjectsApi::deleteOrgProject",
    "Upsun\\Api\\OrganizationProjectsApi::queryProjectCarbon",
    "Upsun\\Api\\OrganizationProjectsApi::updateOrgProject",
    "Upsun\\Api\\UsersApi::getCurrentUserDeprecated",
    "Upsun\\Api\\AlertsApi::getUsageAlerts",
    "Upsun\\Api\\AlertsApi::updateUsageAlerts",
    "Upsun\\Api\\DefaultApi::queryOrganiationCarbon",
    "Upsun\\Api\\OrganizationManagementApi::estimateOrg",
    "Upsun\\Api\\OrganizationManagementApi::getOrgBillingAlertConfig",
    "Upsun\\Api\\OrganizationManagementApi::getOrgPrepaymentInfo",
    "Upsun\\Api\\OrganizationManagementApi::listOrgPrepaymentTransactions",
    "Upsun\\Api\\OrganizationManagementApi::updateOrgBillingAlertConfig",
    "Upsun\\Api\\DiscountsApi::getDiscount",
    "Upsun\\Api\\DiscountsApi::getTypeAllowance",
    "Upsun\\Api\\DiscountsApi::listOrgDiscounts"
  ],
  "invalid_facade_calls": [],
  "coverage_percentage": 82.98
}

@platformsh-devrel
Copy link
Collaborator

platformsh-devrel commented Nov 19, 2025

🧾 API Coverage Report

Last updated: 255c39e • Run #113

Metric Value
Total API methods 235
Called from facades 195
Unmapped API methods 40
Invalid Facade API calls 0
Coverage 82.98%
📋 Full JSON report 
{
  "total_api_methods": 235,
  "called_methods": 195,
  "unmapped_methods": [
    "Upsun\\Api\\SshKeysApi::createSshKey",
    "Upsun\\Api\\SshKeysApi::deleteSshKey",
    "Upsun\\Api\\SshKeysApi::getSshKey",
    "Upsun\\Api\\AutoscalingApi::getAutoscalerSettings",
    "Upsun\\Api\\AutoscalingApi::patchAutoscalerSettings",
    "Upsun\\Api\\AutoscalingApi::postAutoscalerSettings",
    "Upsun\\Api\\CertificateProvisionerApi::getProjectsProvisioners",
    "Upsun\\Api\\CertificateProvisionerApi::listProjectsProvisioners",
    "Upsun\\Api\\CertificateProvisionerApi::updateProjectsProvisioners",
    "Upsun\\Api\\EnvironmentApi::deployEnvironment",
    "Upsun\\Api\\ReferencesApi::listReferencedOrgs",
    "Upsun\\Api\\ReferencesApi::listReferencedProjects",
    "Upsun\\Api\\ReferencesApi::listReferencedRegions",
    "Upsun\\Api\\ReferencesApi::listReferencedTeams",
    "Upsun\\Api\\ReferencesApi::listReferencedUsers",
    "Upsun\\Api\\ProjectApi::actionProjectsClearBuildCache",
    "Upsun\\Api\\UserProfilesApi::createProfilePicture",
    "Upsun\\Api\\SubscriptionsApi::canUpdateSubscription",
    "Upsun\\Api\\SubscriptionsApi::getOrgSubscription",
    "Upsun\\Api\\SubscriptionsApi::getSubscriptionUsageAlerts",
    "Upsun\\Api\\SubscriptionsApi::listOrgSubscriptions",
    "Upsun\\Api\\SubscriptionsApi::listSubscriptionAddons",
    "Upsun\\Api\\SubscriptionsApi::updateOrgSubscription",
    "Upsun\\Api\\SubscriptionsApi::updateSubscriptionUsageAlerts",
    "Upsun\\Api\\OrganizationProjectsApi::createOrgProject",
    "Upsun\\Api\\OrganizationProjectsApi::deleteOrgProject",
    "Upsun\\Api\\OrganizationProjectsApi::queryProjectCarbon",
    "Upsun\\Api\\OrganizationProjectsApi::updateOrgProject",
    "Upsun\\Api\\UsersApi::getCurrentUserDeprecated",
    "Upsun\\Api\\AlertsApi::getUsageAlerts",
    "Upsun\\Api\\AlertsApi::updateUsageAlerts",
    "Upsun\\Api\\DefaultApi::queryOrganiationCarbon",
    "Upsun\\Api\\OrganizationManagementApi::estimateOrg",
    "Upsun\\Api\\OrganizationManagementApi::getOrgBillingAlertConfig",
    "Upsun\\Api\\OrganizationManagementApi::getOrgPrepaymentInfo",
    "Upsun\\Api\\OrganizationManagementApi::listOrgPrepaymentTransactions",
    "Upsun\\Api\\OrganizationManagementApi::updateOrgBillingAlertConfig",
    "Upsun\\Api\\DiscountsApi::getDiscount",
    "Upsun\\Api\\DiscountsApi::getTypeAllowance",
    "Upsun\\Api\\DiscountsApi::listOrgDiscounts"
  ],
  "invalid_facade_calls": [],
  "coverage_percentage": 82.98
}

@platformsh-devrel
Copy link
Collaborator

platformsh-devrel commented Nov 19, 2025

🧾 API Coverage Report

Last updated: 6132e1d • Run #114

Metric Value
Total API methods 235
Called from facades 195
Unmapped API methods 40
Invalid Facade API calls 0
Coverage 82.98%
📋 Full JSON report 
{
  "total_api_methods": 235,
  "called_methods": 195,
  "unmapped_methods": [
    "Upsun\\Api\\SshKeysApi::createSshKey",
    "Upsun\\Api\\SshKeysApi::deleteSshKey",
    "Upsun\\Api\\SshKeysApi::getSshKey",
    "Upsun\\Api\\AutoscalingApi::getAutoscalerSettings",
    "Upsun\\Api\\AutoscalingApi::patchAutoscalerSettings",
    "Upsun\\Api\\AutoscalingApi::postAutoscalerSettings",
    "Upsun\\Api\\CertificateProvisionerApi::getProjectsProvisioners",
    "Upsun\\Api\\CertificateProvisionerApi::listProjectsProvisioners",
    "Upsun\\Api\\CertificateProvisionerApi::updateProjectsProvisioners",
    "Upsun\\Api\\EnvironmentApi::deployEnvironment",
    "Upsun\\Api\\ReferencesApi::listReferencedOrgs",
    "Upsun\\Api\\ReferencesApi::listReferencedProjects",
    "Upsun\\Api\\ReferencesApi::listReferencedRegions",
    "Upsun\\Api\\ReferencesApi::listReferencedTeams",
    "Upsun\\Api\\ReferencesApi::listReferencedUsers",
    "Upsun\\Api\\ProjectApi::actionProjectsClearBuildCache",
    "Upsun\\Api\\UserProfilesApi::createProfilePicture",
    "Upsun\\Api\\SubscriptionsApi::canUpdateSubscription",
    "Upsun\\Api\\SubscriptionsApi::getOrgSubscription",
    "Upsun\\Api\\SubscriptionsApi::getSubscriptionUsageAlerts",
    "Upsun\\Api\\SubscriptionsApi::listOrgSubscriptions",
    "Upsun\\Api\\SubscriptionsApi::listSubscriptionAddons",
    "Upsun\\Api\\SubscriptionsApi::updateOrgSubscription",
    "Upsun\\Api\\SubscriptionsApi::updateSubscriptionUsageAlerts",
    "Upsun\\Api\\OrganizationProjectsApi::createOrgProject",
    "Upsun\\Api\\OrganizationProjectsApi::deleteOrgProject",
    "Upsun\\Api\\OrganizationProjectsApi::queryProjectCarbon",
    "Upsun\\Api\\OrganizationProjectsApi::updateOrgProject",
    "Upsun\\Api\\UsersApi::getCurrentUserDeprecated",
    "Upsun\\Api\\AlertsApi::getUsageAlerts",
    "Upsun\\Api\\AlertsApi::updateUsageAlerts",
    "Upsun\\Api\\DefaultApi::queryOrganiationCarbon",
    "Upsun\\Api\\OrganizationManagementApi::estimateOrg",
    "Upsun\\Api\\OrganizationManagementApi::getOrgBillingAlertConfig",
    "Upsun\\Api\\OrganizationManagementApi::getOrgPrepaymentInfo",
    "Upsun\\Api\\OrganizationManagementApi::listOrgPrepaymentTransactions",
    "Upsun\\Api\\OrganizationManagementApi::updateOrgBillingAlertConfig",
    "Upsun\\Api\\DiscountsApi::getDiscount",
    "Upsun\\Api\\DiscountsApi::getTypeAllowance",
    "Upsun\\Api\\DiscountsApi::listOrgDiscounts"
  ],
  "invalid_facade_calls": [],
  "coverage_percentage": 82.98
}

@flovntp flovntp force-pushed the fix-rector-timing branch 2 times, most recently from 3cec0b4 to 0d73533 Compare November 19, 2025 09:29
@platformsh-devrel
Copy link
Collaborator

platformsh-devrel commented Nov 19, 2025

⚠️ API Coverage Analysis Failed

The coverage analysis encountered an error during execution.

Check the workflow run for details.

@platformsh-devrel
Copy link
Collaborator

platformsh-devrel commented Nov 19, 2025

⚠️ API Coverage Analysis Failed

The coverage analysis encountered an error during execution.

Check the workflow run for details.

@platformsh-devrel
Copy link
Collaborator

platformsh-devrel commented Nov 19, 2025

⚠️ API Coverage Analysis Failed

The coverage analysis encountered an error during execution.

Check the workflow run for details.

@platformsh-devrel
Copy link
Collaborator

platformsh-devrel commented Nov 19, 2025

🧾 API Coverage Report

Last updated: 94b433e • Run #119

Metric Value
Total API methods 235
Called from facades 195
Unmapped API methods 40
Invalid Facade API calls 0
Coverage 82.98%
📋 Full JSON report 
{
  "total_api_methods": 235,
  "called_methods": 195,
  "unmapped_methods": [
    "Upsun\\Api\\SshKeysApi::createSshKey",
    "Upsun\\Api\\SshKeysApi::deleteSshKey",
    "Upsun\\Api\\SshKeysApi::getSshKey",
    "Upsun\\Api\\AutoscalingApi::getAutoscalerSettings",
    "Upsun\\Api\\AutoscalingApi::patchAutoscalerSettings",
    "Upsun\\Api\\AutoscalingApi::postAutoscalerSettings",
    "Upsun\\Api\\CertificateProvisionerApi::getProjectsProvisioners",
    "Upsun\\Api\\CertificateProvisionerApi::listProjectsProvisioners",
    "Upsun\\Api\\CertificateProvisionerApi::updateProjectsProvisioners",
    "Upsun\\Api\\EnvironmentApi::deployEnvironment",
    "Upsun\\Api\\ReferencesApi::listReferencedOrgs",
    "Upsun\\Api\\ReferencesApi::listReferencedProjects",
    "Upsun\\Api\\ReferencesApi::listReferencedRegions",
    "Upsun\\Api\\ReferencesApi::listReferencedTeams",
    "Upsun\\Api\\ReferencesApi::listReferencedUsers",
    "Upsun\\Api\\ProjectApi::actionProjectsClearBuildCache",
    "Upsun\\Api\\UserProfilesApi::createProfilePicture",
    "Upsun\\Api\\SubscriptionsApi::canUpdateSubscription",
    "Upsun\\Api\\SubscriptionsApi::getOrgSubscription",
    "Upsun\\Api\\SubscriptionsApi::getSubscriptionUsageAlerts",
    "Upsun\\Api\\SubscriptionsApi::listOrgSubscriptions",
    "Upsun\\Api\\SubscriptionsApi::listSubscriptionAddons",
    "Upsun\\Api\\SubscriptionsApi::updateOrgSubscription",
    "Upsun\\Api\\SubscriptionsApi::updateSubscriptionUsageAlerts",
    "Upsun\\Api\\OrganizationProjectsApi::createOrgProject",
    "Upsun\\Api\\OrganizationProjectsApi::deleteOrgProject",
    "Upsun\\Api\\OrganizationProjectsApi::queryProjectCarbon",
    "Upsun\\Api\\OrganizationProjectsApi::updateOrgProject",
    "Upsun\\Api\\UsersApi::getCurrentUserDeprecated",
    "Upsun\\Api\\AlertsApi::getUsageAlerts",
    "Upsun\\Api\\AlertsApi::updateUsageAlerts",
    "Upsun\\Api\\DefaultApi::queryOrganiationCarbon",
    "Upsun\\Api\\OrganizationManagementApi::estimateOrg",
    "Upsun\\Api\\OrganizationManagementApi::getOrgBillingAlertConfig",
    "Upsun\\Api\\OrganizationManagementApi::getOrgPrepaymentInfo",
    "Upsun\\Api\\OrganizationManagementApi::listOrgPrepaymentTransactions",
    "Upsun\\Api\\OrganizationManagementApi::updateOrgBillingAlertConfig",
    "Upsun\\Api\\DiscountsApi::getDiscount",
    "Upsun\\Api\\DiscountsApi::getTypeAllowance",
    "Upsun\\Api\\DiscountsApi::listOrgDiscounts"
  ],
  "invalid_facade_calls": [],
  "coverage_percentage": 82.98
}

@flovntp flovntp force-pushed the fix-rector-timing branch 2 times, most recently from 7dfa57f to cbeb412 Compare November 19, 2025 10:01
@flovntp flovntp merged commit 82f9931 into main Nov 20, 2025
9 checks passed
@flovntp flovntp deleted the fix-rector-timing branch November 20, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flovntp @platformsh-devrel