Skip to content

feat: range vectors using an id prefix #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heyjorgedev merged 1 commit into from
Mar 3, 2025
Merged

feat: range vectors using an id prefix #18

heyjorgedev merged 1 commit into from
Mar 3, 2025

Conversation

@heyjorgedev
Copy link
Contributor

@heyjorgedev heyjorgedev commented Feb 28, 2025

This PR introduces a new property on `VectorRange´ that allows iteration on database records using an id prefix:

$results = $this->namespace->rangeIterator(new VectorRange(limit: 10, prefix: 'prefix-'));

@linear
Copy link

linear bot commented Feb 28, 2025

DX-1668 PHP: Support range with id prefix for Vector

yunusemreozdemir
yunusemreozdemir approved these changes Mar 3, 2025
View reviewed changes
Copy link

@yunusemreozdemir yunusemreozdemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along the same lines with vector-py implementation, good tests.

@heyjorgedev heyjorgedev merged commit e5afd05 into master Mar 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yunusemreozdemir yunusemreozdemir yunusemreozdemir approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heyjorgedev @yunusemreozdemir