Open
Conversation
olxmpe
reviewed
Feb 16, 2026
| } | ||
|
|
||
| get buttonStyle(): string { | ||
| return this.args.buttonStyle === 'icon' ? 'icon' : 'button'; |
Contributor
There was a problem hiding this comment.
Suggested change
| return this.args.buttonStyle === 'icon' ? 'icon' : 'button'; | |
| return this.args.buttonStyle ?? 'button'; |
| } | ||
|
|
||
| get containerElement(): HTMLElement { | ||
| return document.querySelector(`#${this.scrollableBarId} .inner-container`) as HTMLElement; |
Contributor
There was a problem hiding this comment.
If for any reason this.containerElement is undefined, this.scrollWith will break, I'm not sure about as HTMLElement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR implements a new
OSS::ScrollableBarcomponent.This new component displays a scrollable row of items given in its
contentnamed block. Buttons are displayed on the far right and left depending on the scroll state.This new component also supports two different designs, thanks to a
buttonStylearg, defaulting to "button" style.Additional information about the scroll performed when clicking on the buttons: the amount of scroll depends directly on the container size. The scroll step width is currently 33% of the scrollable container.
Related tests, documentation, and examples, have been added.
Related to: #
What are the observable changes?
Enregistrement.de.l.ecran.2026-02-16.a.14.24.53.mov
Good PR checklist