Skip to content

POC - OSS::ScrollablePanel to feature scroll buttons for horizontal scrolling #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Miexil wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

POC - OSS::ScrollablePanel to feature scroll buttons for horizontal scrolling #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caa9bc7
POC - OSS::ScrollablePanel to feature scroll buttons for horizontal s…
Miexil Feb 13, 2026
a45ee21
Updated: scroll buttons & adaptive scroll length
Miexil Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions addon/components/o-s-s/scrollable-panel.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,21 @@
{{on-bottom-reached this.onBottomReached}}
{{did-insert this.initScrollListener}}
>
{{#if (and @displayScrollArrows this.shadowLeftVisible)}}
<OSS::Button @square={{true}} @icon="fa-chevron-left" class="scroll-arrow-left" {{on "click" this.scrollToStart}} />
{{/if}}
<div {{did-insert this.initResizeObserver}}>
{{yield}}
</div>
{{#if (and @displayScrollArrows this.shadowRightVisible)}}
<OSS::Button @square={{true}} @icon="fa-chevron-right" class="scroll-arrow-right" {{on "click" this.scrollToEnd}} />
{{/if}}
</div>
{{#if (and this.shadowBottomVisible (not @disableShadows))}}
<div class="oss-scrollable-panel--shadow oss-scrollable-panel--shadow__bottom"></div>
{{/if}}
{{#if (and this.shadowRightVisible (not @disableShadows))}}
<div class="oss-scrollable-panel--shadow oss-scrollable-panel--shadow__right"></div>
{{/if}}

</div>
21 changes: 20 additions & 1 deletion addon/components/o-s-s/scrollable-panel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ interface OSSScrollablePanelComponentSignature {
horizontal?: boolean;
hideScrollbar?: boolean;
offset?: number;
displayScrollArrows?: boolean;
onBottomReached?: () => void;
}

Expand All @@ -19,6 +20,7 @@ export default class OSSScrollablePanelComponent extends Component<OSSScrollable
@tracked shadowRightVisible: boolean = false;

resizeObserver = new ResizeObserver(this.resizeObserverCallback.bind(this));
mutationObserver = new MutationObserver(this.resizeObserverCallback.bind(this));

get offset(): number {
return this.args.offset ?? 0;
Expand All @@ -39,6 +41,7 @@ export default class OSSScrollablePanelComponent extends Component<OSSScrollable
@action
initResizeObserver(element: HTMLElement): void {
this.resizeObserver.observe(element);
this.mutationObserver.observe(element, { childList: true, subtree: true });
}

@action
Expand All @@ -58,6 +61,22 @@ export default class OSSScrollablePanelComponent extends Component<OSSScrollable
this.args.onBottomReached?.();
}

@action
scrollToStart(): void {
this.parentElement.scrollTo({
left: this.parentElement.scrollLeft - this.parentElement.clientWidth,
behavior: 'smooth'
});
}

@action
scrollToEnd(): void {
this.parentElement.scrollTo({
left: this.parentElement.scrollLeft + this.parentElement.clientWidth,
behavior: 'smooth'
});
}

private scrollListener(): void {
if (this.parentElement.scrollTop - this.offset > 0) {
this.shadowTopVisible = true;
Expand Down Expand Up @@ -98,7 +117,7 @@ export default class OSSScrollablePanelComponent extends Component<OSSScrollable
}
}

private resizeObserverCallback(_: ResizeObserverEntry[]): void {
private resizeObserverCallback(_: (ResizeObserverEntry | MutationRecord)[]): void {
if (this.args.horizontal) {
this.horizontalScrollListener();
} else {
Expand Down
23 changes: 23 additions & 0 deletions app/styles/organisms/scrollable-panel.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,27 @@
}
}
}

.scroll-arrow-right {
position: absolute;
right: 8px;
top: 50%;
transform: translateY(-50%);
z-index: 20;
align-items: center;
align-content: center;
cursor: pointer;
}

.scroll-arrow-left {
position: absolute;
left: 8px;
top: 50%;
transform: translateY(-50%);
z-index: 2;
// border-radius: 50%;
align-items: center;
align-content: center;
cursor: pointer;
}
}
7 changes: 6 additions & 1 deletion tests/dummy/app/controllers/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default class Data extends Controller {
@tracked revealed: boolean = false;
@tracked starRatingValue: number = 3;

loop: null[] = Array(15);
@tracked loop: null[] = Array(15);

subdomainRegex: RegExp = /^[a-zA-Z0-9]+[a-zA-Z0-9-._]*[a-zA-Z0-9]+$/;

Expand Down Expand Up @@ -99,4 +99,9 @@ export default class Data extends Controller {
}, 1000);
});
}

@action
addToLoop(): void {
this.loop = [...this.loop, null];
}
}
13 changes: 8 additions & 5 deletions tests/dummy/app/templates/data.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
Scrollable panel
</div>
<div class="fx-row fx-gap-px-24 fx-xalign-start">
<div class="fx-row fx-gap-px-24 fx-xalign-start" style="height: 300px; width: 500px;">
{{!-- <div class="fx-row fx-gap-px-24 fx-xalign-start" style="height: 300px; width: 500px;">
<OSS::ScrollablePanel>
<div class="fx-col fx-gap-px-6">
{{#each this.loop}}
Expand All @@ -82,17 +82,20 @@
{{/each}}
</div>
</OSS::ScrollablePanel>
</div>
</div> --}}
<div class="fx-row fx-gap-px-24 fx-xalign-start" style="width: 500px;">
<OSS::ScrollablePanel @plain={{true}} @horizontal={{true}} @hideScrollbar={{true}}>
<OSS::ScrollablePanel @plain={{true}} @horizontal={{true}} @hideScrollbar={{true}} @disableScrollShadows={{true}} @displayScrollArrows={{true}}>
<div class="fx-row fx-gap-px-6" style="width: fit-content;">
{{#each this.loop}}
<OSS::Tag @label="toto" />
{{#each this.loop as |item index|}}
{{!-- <OSS::Tag @label={{concat "nb:" index}} /> --}}
<OSS::Button @label={{concat "nb:" index}} />
{{/each}}
</div>
</OSS::ScrollablePanel>
</div>
</div>
<OSS::Button {{on "click" this.addToLoop}} @label="Add item to loop" />
loop count: {{this.loop.length}}
</div>

<div
Expand Down
Loading