[hypertable] sonar config + fix codes smells + fix flaky test#258
Merged
[hypertable] sonar config + fix codes smells + fix flaky test#258
Conversation
Miexil
requested review from
Elodie-DeMatteis-Upf and
aprentout
and removed request for
a team
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on September 28. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
# Conflicts: # tests/integration/components/hyper-table/cell-renderers/image-test.js
phndiaye
reviewed
Sep 18, 2025
| const availableHeight = tableBottom - colHeaderTop - 100; | ||
|
|
||
| dropdown.style.height = `${availableHeight}px`; | ||
| dropdown.style.maxHeight = `${availableHeight}px`; |
aprentout
approved these changes
Sep 18, 2025
phndiaye
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[hypertable] sonar config + fix codes smells + fix flaky test
Coverage improved from 44% to 84%
Good PR checklist