Skip to content

[hypertable] Updated row height #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathalieArnoux merged 4 commits into from
Sep 10, 2025
Merged

[hypertable] Updated row height #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87c3df8
Updated row height
nathalieArnoux Sep 1, 2025
dbca0d6
Updated image cell renderer to use OSS Avatar
nathalieArnoux Sep 2, 2025
ad22231
Changed number of rows per page
nathalieArnoux Sep 10, 2025
67e2678
Fixed broken test
nathalieArnoux Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/components/hyper-table/cell-renderers/image.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div>
{{upf-image src=this.imageURL classNames="upf-image--round-36"}}
<OSS::Avatar @image={{this.imageURL}} @size="sm" @initials={{this.initials}} />
</div>

{{#if (gt @column.labels.length 0)}}
Expand Down
10 changes: 10 additions & 0 deletions addon/components/hyper-table/cell-renderers/image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,14 @@ export default class ImageCellRenderer extends Component {
get imageURL() {
return get(this.args.item, this.args.column.key);
}

get initials() {
return (
(get(this.args.item, this.args.column.labels[0]) || '')
.match(/\b[a-zA-Z]/g)
Copy link
Contributor

@olxmpe olxmpe Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we use nameInitials helper from ember-upf-utils?

Copy link
Contributor Author

@nathalieArnoux nathalieArnoux Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was considered, but the helper is not handling special characters correctly and created issues with certain profile names :/

?.slice(0, 2)
.join('')
.toUpperCase() || ''
);
}
}
4 changes: 3 additions & 1 deletion addon/core/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ import { isEmpty } from '@ember/utils';

export type RowMutator = (row: Row) => boolean;

const ROWS_PER_PAGE = 30;

export default class TableHandler {
private _context: unknown;
private _renderingResolver?: RendererResolver;
Expand Down Expand Up @@ -103,7 +105,7 @@ export default class TableHandler {
this.loadingRows = true;

return this.rowsFetcher
.fetch(this.currentPage, 20)
.fetch(this.currentPage, ROWS_PER_PAGE)
.then(({ rows, meta }) => {
this.rows = [...this.rows, ...rows.filter((row) => !this.rows.map((r) => r.record_id).includes(row.record_id))];
this.rowsMeta = meta;
Expand Down
4 changes: 2 additions & 2 deletions app/styles/cells.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@cell-height: 60px;
@cell-height: 50px;

.hypertable__cell {
border-bottom: 1px solid var(--color-border-default);
Expand All @@ -9,7 +9,7 @@

height: @cell-height;
max-height: @cell-height;
padding: var(--spacing-px-12);
padding: var(--spacing-px-3) var(--spacing-px-12);
width: 100%;

.ember-flatpickr-input {
Expand Down
2 changes: 1 addition & 1 deletion app/styles/columns.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
z-index: 15;
height: @cell-height;
max-height: @cell-height;
padding: var(--spacing-px-12) var(--spacing-px-18);
padding: var(--spacing-px-3) var(--spacing-px-12);
border-left: 1px solid var(--color-border-default);
border-bottom: 1px solid var(--color-border-default);
width: 100%;
Expand Down
12 changes: 3 additions & 9 deletions tests/integration/components/hyper-table/cell-renderers/image-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ module('Integration | Component | hyper-table/cell-renderers/image', function (h

await render(hbs`<HyperTable::CellRenderers::Image @item={{this.item}} @column={{this.column}} />`);

assert
.dom('div.upf-image.upf-image--round-36')
.hasAttribute('style', 'background-image: url("foo.png"), url("assets/images/no-image.svg");');
assert.dom('.upf-avatar.upf-avatar--sm img').hasAttribute('src', 'foo.png');
});

module('it has labels to show', function () {
Expand All @@ -24,9 +22,7 @@ module('Integration | Component | hyper-table/cell-renderers/image', function (h

await render(hbs`<HyperTable::CellRenderers::Image @item={{this.item}} @column={{this.column}} />`);

assert
.dom('div.upf-image.upf-image--round-36')
.hasAttribute('style', 'background-image: url("foo.png"), url("assets/images/no-image.svg");');
assert.dom('.upf-avatar.upf-avatar--sm img').exists();

assert.dom('span.margin-left-xx-sm.text-ellipsis-160').hasText('FooBar');
});
Expand All @@ -39,9 +35,7 @@ module('Integration | Component | hyper-table/cell-renderers/image', function (h

await render(hbs`<HyperTable::CellRenderers::Image @item={{this.item}} @column={{this.column}} />`);

assert
.dom('div.upf-image.upf-image--round-36')
.hasAttribute('style', 'background-image: url("foo.png"), url("assets/images/no-image.svg");');
assert.dom('.upf-avatar.upf-avatar--sm img').exists();

assert.dom('span.margin-left-xx-sm.text-ellipsis-160').hasText('FooBar');
assert.dom('span.upf-notification--inline').exists();
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/core/handler-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ module('Unit | core/handler', function (hooks) {
// @ts-ignore
assert.ok(rowsFetcherSpy.fetch.calledTwice);
// @ts-ignore
assert.ok(rowsFetcherSpy.fetch.calledWithExactly(1, 20));
assert.ok(rowsFetcherSpy.fetch.calledWithExactly(1, 30));
assert.equal(handler.rows.length, 3);
});

Expand Down