Added locked state on list cell renderer#220
Merged
OwenCoogan merged 6 commits intomasterfrom Jan 9, 2025
Merged
Conversation
OwenCoogan
requested review from
JulienVannier66 and
Xegushu
and removed request for
a team
phndiaye
reviewed
Dec 31, 2024
Member
There was a problem hiding this comment.
can you make this a computed instead ?
phndiaye
reviewed
Dec 31, 2024
translations/en-us.yaml
Outdated
Comment on lines
89
to
95
Member
There was a problem hiding this comment.
not super fan of having this in this project tbh. it's highly bound to upfluence context which this project isn't. we can discuss it live if you want
Miexil
approved these changes
Jan 6, 2025
nathalieArnoux
approved these changes
Jan 7, 2025
phndiaye
approved these changes
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to : #
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes