hyper-table-v2/filtering-renderers/date: allow moving option key to be extended#216
Merged
hyper-table-v2/filtering-renderers/date: allow moving option key to be extended#216
Conversation
phndiaye
requested review from
Xegushu,
aprentout and
nathalieArnoux
and removed request for
a team
upfluence-bot
added
reviewed/ready-to-merge
and removed
reviewed/needs-review
reviewed/ready-to-merge
labels
Xegushu
approved these changes
Nov 15, 2024
phndiaye
force-pushed
the
pn/vel-4194
branch
2 times, most recently
from
164f703 to
f45e6ee
Compare
* hypertable v2: add support for empty_state_message * add more test scenarios for rows and fix tests * hyper-table-v2/filtering-renderers/numeric: add multiplier option, allows for extension in money-type columns
…or passing a filterKey
phndiaye
force-pushed
the
pn/vel-4194
branch
from
0b0451a to
6f0e8bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
hyper-table-v2/filtering-renderers/date: allow moving option key to be extended in case the backend the API expects a different value.
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist
Additional Notes