Skip to content

Updated: use staging activity URL by default#19

Merged
Miexil merged 1 commit intomainfrom
mb/proper-activity-url
Oct 22, 2025
Merged

Updated: use staging activity URL by default#19
Miexil merged 1 commit intomainfrom
mb/proper-activity-url

Conversation

@Miexil
Copy link
Member

@Miexil Miexil commented Oct 21, 2025

What does this PR do?

Modifies naming of the activityURL so that it can be overwritten by parent projects.

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

@Miexil Miexil self-assigned this Oct 21, 2025
@Miexil Miexil requested review from a team and phndiaye as code owners October 21, 2025 14:47
@Miexil Miexil requested review from Elodie-DeMatteis-Upf and nathalieArnoux and removed request for a team October 21, 2025 14:47
@Miexil Miexil force-pushed the mb/proper-activity-url branch from cf50b03 to a4ba72b Compare October 21, 2025 15:26
Copy link
Member

@phndiaye phndiaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the configuration, what about using getOwnConfig instead ?

It's setup like this in settings-web: https://github.com/upfluence/upfluence-web/blob/670cbe2c5f6f33c5a6e629f20a2748b31c480989/packages/settings-web/index.js#L59-L87.

Then where needed, it would getOwnConfig().activityUrl (which i would've kept to backendActivityUrl, personally). I believe we skipped the backend prefix for variables leading to frontends (like identityUrl for example)

This also means the addon will be responsible of its setup without having to pass the variable through parent apps.

@phndiaye
Copy link
Member

For the configuration, what about using getOwnConfig instead ?

It's setup like this in settings-web: upfluence/upfluence-web@670cbe2/packages/settings-web/index.js#L59-L87.

Then where needed, it would getOwnConfig().activityUrl (which i would've kept to backendActivityUrl, personally). I believe we skipped the backend prefix for variables leading to frontends (like identityUrl for example)

This also means the addon will be responsible of its setup without having to pass the variable through parent apps.

Discussed live, let's keep it as is for now ;)

@Miexil Miexil merged commit 754f440 into main Oct 22, 2025
3 checks passed
@Miexil Miexil deleted the mb/proper-activity-url branch October 22, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments