Skip to content

Extract google maps loader to service#451

Merged
JulienVannier66 merged 2 commits intofeature/payment-requests-onboarding-reworkfrom
jv/vel-7196/extract-google-maps-loader-to-service
Feb 5, 2026
Merged

Extract google maps loader to service#451
JulienVannier66 merged 2 commits intofeature/payment-requests-onboarding-reworkfrom
jv/vel-7196/extract-google-maps-loader-to-service

Conversation

@JulienVannier66
Copy link
Contributor

What does this PR do?

This PR extracts the Google Maps loader logic from the setup-autocomplete modifier into a dedicated autocomplete-handler service, improving testability and separation of concerns.

Key changes:

  • Created AutocompleteHandlerService that centralizes Google Maps loader instantiation
  • Removed the loader parameter from setup-autocomplete modifier (now injected via service)
  • Added AutocompleteHandlerServiceMock for testing with MockLoader
  • Updated all tests to register the mock service instead of passing the loader directly
  • Added unit tests for both production and test service implementations

What are the observable changes?

🧑‍💻 Developer Heads Up

⚡ Since we are using Ember Octane now:

  • Feel free to migrate existing components to Glimmer Components.
  • Write new ones exclusively in it.

Useful Resource : Ember Octane vs Classic Cheat Sheet

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Migrated touched components to Glimmer Components
  • Properly labeled

@JulienVannier66 JulienVannier66 self-assigned this Feb 3, 2026
@JulienVannier66 JulienVannier66 requested review from a team and phndiaye as code owners February 3, 2026 15:25
@JulienVannier66 JulienVannier66 requested review from Elodie-DeMatteis-Upf and OwenCoogan and removed request for a team February 3, 2026 15:25
@linear
Copy link

linear bot commented Feb 3, 2026

@JulienVannier66 JulienVannier66 force-pushed the jv/vel-7196/extract-google-maps-loader-to-service branch from 188ebaa to e9db417 Compare February 3, 2026 15:33
@JulienVannier66 JulienVannier66 merged commit 3ff68aa into feature/payment-requests-onboarding-rework Feb 5, 2026
2 checks passed
@JulienVannier66 JulienVannier66 deleted the jv/vel-7196/extract-google-maps-loader-to-service branch February 5, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants