Merged
Conversation
Collaborator
tillpiepenbrock
commented
Oct 17, 2025
tillpiepenbrock
commented
- Filters have been introduced to give bounds to the data which is used for fitting the permeability.
- Documentation-ready plots of permeability and permittivity have been added
gituser789
requested changes
Oct 17, 2025
| import os | ||
| from typing import Tuple | ||
| from typing import Tuple, Optional, List | ||
|
|
Contributor
There was a problem hiding this comment.
we should use python >3.11 new keys
directly in the code
list without any import
optional replaces e.g. to float | None
| grid_f_kHz = grid_f * 1e-3 # convert Hz → kHz | ||
|
|
||
| # --- Helper function to compute |mu| and phase --- | ||
| def interpolate_mu(dft): |
Contributor
There was a problem hiding this comment.
small descripton missing
| """Class to represent the data structure and load material data.""" | ||
| # python libraries | ||
| from typing import List | ||
| from typing import List, Optional |
Contributor
There was a problem hiding this comment.
same here
use e.g. float | None in the code
gituser789
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.