-
Notifications
You must be signed in to change notification settings - Fork 45
feat: add database capabilities #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
23b2d24 to
30172ac
Compare
docs/1.guide/2.capabilities.md
Outdated
|
|
||
| ## Capabilities by Connector | ||
|
|
||
| | Connector | JSON | Bool | Array | Date | UUID | Tx | Batch | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice if we add an automd generator for this section to stay in sync with source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it looks like a dialect-mapped table. I suggest exposing it as a subpath like db0/capabilities with a map from dialects to capabilities users can use.
Later we might only expose capabilityOverrides from connectors that have exception (for example have one less or extra feature)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i amended pr with this comments
a8ce927 to
3a1343b
Compare
@pi0 , let me know how we can proceed :) |
7a1e2fb to
f6f8fb3
Compare
fa3cc18 to
a1161db
Compare
Summary
db.capabilitiesproperty to query database feature support at runtimeChanges
Per pi0's suggestion:
db0/capabilitiessubpath withdialectCapabilitiesmap andgetCapabilities()helpercapabilityOverrides(optional) for exceptions instead of full capabilitiesOther:
DatabaseCapabilitiesinterface with 7 capability flagsCapabilities Matrix
TODOs
currently using the
db-compat.onmax.medeployment in the docs and github source code