Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage ? 41.47%
=======================================
Files ? 23
Lines ? 892
Branches ? 91
=======================================
Hits ? 370
Misses ? 516
Partials ? 6 ☔ View full report in Codecov by Sentry. |
| return getConnection().then((c) => c(this._sql, params || this._params)); | ||
| }, | ||
| run(...params) { | ||
| return getConnection().then((c) => c(this._sql, params || this._params)); |
There was a problem hiding this comment.
run is supposed to only return success right? currently we are returning whatever we get back, so I should change that?
There was a problem hiding this comment.
Can you confirm what is production behavior of neon currently? Ideally if it returns additional info, it seems to be correct.
There was a problem hiding this comment.
I'm so sorry, I've missed your comments 🥲 sure that sounds good
| import connector from "../../src/connectors/neon"; | ||
| import { testConnector } from "./_tests"; | ||
|
|
||
| describe.runIf(process.env.POSTGRESQL_URL)( |
There was a problem hiding this comment.
I wish we could somehow mock @neondatabase/serverless (not sure if in their SDK they have it already). We could use something like pglite to emulate their interface in order to allow automated tests.
|
|
||
| export default function neonConnector(opts: ConnectorOptions) { | ||
| let _connection: NeonQueryFunction<undefined, undefined>; | ||
| const getConnection = async () => { |
2 participants
🔗 Linked issue
related to #32
❓ Type of change
📚 Description
this PR adds support for
neonconnector using@neondatabase/serverless+ an example ofneon📝 Checklist