[sub pr: #236] Flow revisions#247
Draft
craftxbox wants to merge 1 commit intounitystation:Hub-Login-revertfrom
Draft
[sub pr: #236] Flow revisions#247craftxbox wants to merge 1 commit intounitystation:Hub-Login-revertfrom
craftxbox wants to merge 1 commit intounitystation:Hub-Login-revertfrom
Conversation
done for the night, unfinished but committing it so it's reviewable somewhat
Bod9001
reviewed
Aug 11, 2025
| var Username = _authService.AccountLoginResponse.Account.Username; | ||
| arguments.Append($"-AccountID {AccountID} "); | ||
| arguments.Append($"-Username {Username} "); | ||
| var CharacterToken = await _authService.GenerateCharacterSheetTokenForFork(Installation.ForkName); |
Member
There was a problem hiding this comment.
This is needed for launching the client directly if you're hosting all playing single player so you can modify your character settings In that scenario
Bod9001
reviewed
Aug 11, 2025
| Encoding.UTF8.GetBytes( | ||
| base64Secret | ||
| + Info.ServerPublicKey | ||
| + Installation.BuildVersion.ToString() |
Member
There was a problem hiding this comment.
You need to send all this crap as part of the token since the malicious server can spoof these to be something else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
done for the night, unfinished but committing it so it's reviewable somewhat