Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/ISSUE_TEMPLATE/architectural-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,3 +125,6 @@ body:
- Background discussions: Link to GitHub Discussions
- Related PRs: #XXX, #YYY
- External references: Papers, benchmarks, etc.

# Reviewed for: Review System Infrastructure & GitHub Integration (Review #10, 2025-11-17)
# Part of formal architectural review process implementation
5 changes: 5 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/architectural-review.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,8 @@ Reviewers: Please review the full document at `docs/reviews/YYYY-MM/[NAME]-REVIE
<!-- Optional: Any other information reviewers should know -->



<!--
REVIEW HISTORY:
- Review #10 (2025-11-17): Template created as part of Review System Infrastructure review
-->
6 changes: 6 additions & 0 deletions .github/workflows/architectural-review-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -174,3 +174,9 @@ jobs:
repo: context.repo.repo,
body: message
});

# Reviewed for: Review System Infrastructure & GitHub Integration (Review #10, 2025-11-17)
# Part of formal architectural review process implementation

# REVIEW HISTORY:
# - Review #10 (2025-11-17): Workflow created as part of Review System Infrastructure review
413 changes: 408 additions & 5 deletions CLAUDE.md

Large diffs are not rendered by default.

183 changes: 0 additions & 183 deletions closure_test_results.txt

This file was deleted.

58 changes: 45 additions & 13 deletions docs/beginner/tutorials/12-Units_System.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,7 @@
"cell_type": "code",
"execution_count": 1,
"metadata": {},
"outputs": [
{
"name": "stdout",
"output_type": "stream",
"text": [
"PostHog telemetry failed: HTTPSConnectionPool(host='eu.i.posthog.com', port=443): Read timed out. (read timeout=10)\n"
]
}
],
"outputs": [],
"source": [
"import nest_asyncio\n",
"nest_asyncio.apply()\n",
Expand Down Expand Up @@ -291,10 +283,50 @@
},
{
"cell_type": "code",
"execution_count": null,
"execution_count": 40,
"metadata": {},
"outputs": [],
"source": []
"outputs": [
{
"data": {
"text/plain": [
"array([0. , 0. , 6.37 , ..., 0.49091125, 1.99139486,\n",
" 0.49345069])"
]
},
"execution_count": 40,
"metadata": {},
"output_type": "execute_result"
}
],
"source": [
"mesh.dm.getCoordinates().array"
]
},
{
"cell_type": "code",
"execution_count": 42,
"metadata": {},
"outputs": [
{
"data": {
"text/plain": [
"UnitAwareArray([[ 0. , 0. ],\n",
" [6370. , 0. ],\n",
" [ 0. , 3185. ],\n",
" ...,\n",
" [ 304.64914035, 301.35283179],\n",
" [5573.30269899, 490.91124502],\n",
" [1991.39486153, 493.45068933]]), callbacks=0, units='kilometer')"
]
},
"execution_count": 42,
"metadata": {},
"output_type": "execute_result"
}
],
"source": [
"mesh.X.coords.to(\"km\")"
]
},
{
"cell_type": "code",
Expand Down Expand Up @@ -782,7 +814,7 @@
"name": "stdout",
"output_type": "stream",
"text": [
"140 μs ± 411 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)\n"
"141 μs ± 338 ns per loop (mean ± std. dev. of 7 runs, 10,000 loops each)\n"
]
}
],
Expand Down
Loading
Loading