Implement file saving functionality #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `file_save` function to write buffer content to the file. - Bind the 's' key to trigger the save action.
There was a problem hiding this comment.
Pull request overview
This PR implements file saving functionality to a text editor application. It allows users to save their buffer content by pressing the 's' key, writing all edited lines back to the original file.
Changes:
- Added
file_savefunction to write the current buffer contents to a file - Moved the 's' key binding from SDL_TEXTINPUT (with CTRL modifier) to SDL_KEYDOWN event handling to trigger file save operation
- Added missing break statement after SDLK_TAB case
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Fair enough, I'm sorry for my stupidity :( |
- Fix the stupid 's' keybinding - Error logging when saving failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file_savefunction to write buffer content to the file.