implemented cli / environment option for disabling HTTP to HTTPS redirect#242
Merged
umputun merged 1 commit intoumputun:masterfrom Feb 13, 2026
Merged
implemented cli / environment option for disabling HTTP to HTTPS redirect#242umputun merged 1 commit intoumputun:masterfrom
umputun merged 1 commit intoumputun:masterfrom
Conversation
umputun
approved these changes
Feb 13, 2026
Owner
umputun
left a comment
umputun
left a comment
There was a problem hiding this comment.
looks good overall, the three-way logic for SSLAuto (DNS-01 vs HTTP-01 with no-redirect) is well thought out.
one minor thing - the PR description mentions NO_REDIRECT env var, but since it's inside the SSL group it's actually SSL_NO_REDIRECT. would be good to fix the description to avoid confusion.
lgtm otherwise, thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds CLI option --ssl.no-redirect and env option NO_REDIRECT - if set, HTTP to HTTPS redirect service is not started.
Rationale: when reproxy is used for terminating HTTPS and forwarding to HTTP server, HTTP to HTTPS redirect on reproxy level is not needed. This option provide way for cleaner setup.