Skip to content

Clarify which thread service runs on #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasonobrien wants to merge 1 commit into
base: TFCM.04-Solution-AddFirebaseMessagingService
Choose a base branch
from
Open

Clarify which thread service runs on #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions app/src/main/java/android/example/com/squawker/fcm/SquawkFirebaseMessageService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,23 +96,12 @@ public void onMessageReceived(RemoteMessage remoteMessage) {
* @param data Map which has the message data in it
*/
private void insertSquawk(final Map<String, String> data) {

// Database operations should not be done on the main thread
AsyncTask<Void, Void, Void> insertSquawkTask = new AsyncTask<Void, Void, Void>() {

@Override
protected Void doInBackground(Void... voids) {
ContentValues newMessage = new ContentValues();
newMessage.put(SquawkContract.COLUMN_AUTHOR, data.get(JSON_KEY_AUTHOR));
newMessage.put(SquawkContract.COLUMN_MESSAGE, data.get(JSON_KEY_MESSAGE).trim());
newMessage.put(SquawkContract.COLUMN_DATE, data.get(JSON_KEY_DATE));
newMessage.put(SquawkContract.COLUMN_AUTHOR_KEY, data.get(JSON_KEY_AUTHOR_KEY));
getContentResolver().insert(SquawkProvider.SquawkMessages.CONTENT_URI, newMessage);
return null;
}
};

insertSquawkTask.execute();
ContentValues newMessage = new ContentValues();
newMessage.put(SquawkContract.COLUMN_AUTHOR, data.get(JSON_KEY_AUTHOR));
newMessage.put(SquawkContract.COLUMN_MESSAGE, data.get(JSON_KEY_MESSAGE).trim());
newMessage.put(SquawkContract.COLUMN_DATE, data.get(JSON_KEY_DATE));
newMessage.put(SquawkContract.COLUMN_AUTHOR_KEY, data.get(JSON_KEY_AUTHOR_KEY));
getContentResolver().insert(SquawkProvider.SquawkMessages.CONTENT_URI, newMessage);
}


Expand Down Expand Up @@ -151,4 +140,4 @@ private void sendNotification(Map<String, String> data) {

notificationManager.notify(0 /* ID of notification */, notificationBuilder.build());
}
}
}