LIBSCHOLAR-61: Fix Coveralls coverage reporting by removing double SimpleCov initialization #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ization - Remove SimpleCov/Coveralls setup from spec_helper.rb to prevent double initialization - Consolidate all coverage setup in rails_helper.rb - Add simplecov-lcov and configure LCOV formatter for CircleCI - Use SimpleCov.formatters (plural) with all three formatters: HTML, LCOV, and Coveralls - Configure formatters before starting SimpleCov to ensure proper setup
Janell-Huyck
changed the title
- Replace SimpleCov.start with Coveralls.wear! to properly handle parallel test execution - Configure formatters before Coveralls.wear! starts SimpleCov - Maintains LCOV formatter for CircleCI upload
Janell-Huyck
changed the title
Janell-Huyck
changed the title
scherztc
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Coveralls integration and stabilize CI coverage reporting
This PR refactors our coverage and CI setup so Coveralls reports accurate, stable coverage, and disables one flaky feature spec.
Coveralls was reporting inconsistent and often too-low coverage because it was getting data twice (once from Ruby and once from CircleCI) and each parallel CircleCI node was independently telling Coveralls the run was finished with only partial data. We simplified things so SimpleCov only generates LCOV output, each parallel node uploads that LCOV through the Coveralls orb, and a single follow-up job sends the final “finished” signal. This gives Coveralls one clear, complete view of the test run, producing stable and accurate coverage numbers.
Simplify and centralize SimpleCov configuration
rails_helper.rb, removing duplicate/complex setup fromspec_helper.rb.SimpleCov::Formatter::MultiFormatterwith HTML + LCOV andsimplecov-lcovsingle-file output, without invokingCoveralls::SimpleCov::Formatterdirectly.Fix Coveralls integration in CircleCI for parallel builds
.circleci/config.yml, keep a singlecoveralls/uploadstep per parallelbuildnode that only uploads the LCOV file.coveralls-finishjob that runs once after all parallelbuildnodes and callscoveralls/uploadwithparallel_finished: true.Stabilize CI by disabling a flaky feature spec
it "allows adding work to a collection"inspec/features/hyrax/work_show_spec.rbasxitwith a comment explaining CI flakiness around the “Add to collection” modal.