WIP - Jump to bulkrax 9 #1183
Open
WIP - Jump to bulkrax 9 #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bulkrax 9.1 routes entry_table as /exporters/:exporter_id/entry_table, but the controller loaded @Exporter from params[:id]. That left @Exporter nil for the JSON request, causing a 500 and the DataTables “Ajax error”. - Add reloader-safe controller decorator to set @Exporter from params[:exporter_id] || params[:id] - Require the decorator via an initializer so it’s applied in dev/test/prod - Keep gem’s _entries_tab and the gem-aligned exporters#show (no custom AJAX URLs) Result: /exporters/:id/entry_table.json responds and the table renders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DTS is great.