Split Google Sheets backend for hardware procurements into BRC- and LRC-specific backends#677
Open
matthew-li wants to merge 4 commits intodevelopfrom
Open
Split Google Sheets backend for hardware procurements into BRC- and LRC-specific backends#677matthew-li wants to merge 4 commits intodevelopfrom
matthew-li wants to merge 4 commits intodevelopfrom
Conversation
* Dynamically display fields in detail view
* Create concrete BRC and LRC subclasses of it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
**** Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. ****
Fixes #676
google_sheetsbackend into two new backends:brc_google_sheetsandlrc_google_sheets, which now have subtle differences in logic:Type of change
**** Please delete options that are not relevant. ****
How Has This Been Tested?
**** Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. ****
pytest.refresh_hardware_procurements_cacheand ensure that no errors occur.PR Self Evaluation
Strikethrough things that don’t make sense for your PR.