Remove invalid pkgconfig files and broken links#300
Closed
sergio-costas wants to merge 2 commits intoubuntu:gnome-46-2404-sdkfrom
Closed
Remove invalid pkgconfig files and broken links#300sergio-costas wants to merge 2 commits intoubuntu:gnome-46-2404-sdkfrom
sergio-costas wants to merge 2 commits intoubuntu:gnome-46-2404-sdkfrom
Conversation
Some soft links to libraries that are already in Core 24, and thus, don't needed, are kept in the SDK. Also, two pkgconfig files are also kept, pointing to the SDK library folder. But since those two libraries (libcrypt and libpciaccess) are already in Core24, and the libraries themselves are deleted, this breaks any build that tries to use any of those. Removing the broken soft links and the pkgconfig files fixes this. With this patch, installing the development .deb packages using the "build-packages" statement in the snapcraft.yaml ensures that the requires build files are available and that no other pkgconfig file will override the correct ones.
Contributor
|
Thanks for looking into it, but I'd rather prefer continue with #294, I'll double-check if we should drop the files or duplicate them again soon. |
Contributor
Author
|
As I already commented, I think that the key point is in the pkgconfig files that shouldn't be there. |
nteodosio
approved these changes
May 5, 2025
Contributor
|
Let's close this for now, as #294 is preferred for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some soft links to libraries that are already in Core 24, and thus, don't needed, are kept in the SDK.
Also, two pkgconfig files are also kept, pointing to the SDK library folder. But since those two libraries (libcrypt and libpciaccess) are already in Core24, and the libraries themselves are deleted, this breaks any build that tries to use any of those.
Removing the broken soft links and the pkgconfig files fixes this. With this patch, installing the development .deb packages using the "build-packages" statement in the snapcraft.yaml ensures that the requires build files are available and that no other pkgconfig file will override the correct ones.