Automatic sync#122
Conversation
feat: added sync template workflow
! You need to link an issue before converting the pull request to ready for review. |
There was a problem hiding this comment.
The pull request does not address the specified task of analyzing GitCoin data and other grant platforms to understand the profit ratios between bounties and grants. The PR instead adds template synchronization functionality. Please provide analysis of grant platform data, revenue/profit metrics, and comparative analysis between bounties and grants as specified in the issue.
0x4007
left a comment
There was a problem hiding this comment.
- Don't use Python. We use typescript everywhere and never use Python or other languages in our stack.
- Use OpenRouter not anthropic directly.
|
There's a part of me that thinks we should break my requests off to a separate task because I reviewed it so late. |
|
Also the linter definitely must not be working because your file naming is wrong. Kebab case only. |
|
I don't think there is any sort of linter here, this is not a typescript project. |
fix: fixed syncTemplate.yml fix: fixed syncTemplate.yml fix: fixed syncTemplate.yml
Automatic sync
Automatic sync
feat: reusable workflow
.github/workflows/sync-templates.yml
Outdated
| REPO_INFO=$(gh api "/repos/${repository}") | ||
| if [[ "$(echo "$REPO_INFO" | jq -r '.template_repository.full_name')" == "${TEMPLATE_REPO}" ]]; then | ||
| REPO_NAME=$(echo "$REPO_INFO" | jq -rc '.full_name') | ||
| ALL_REPOSITORIES+=("${REPO_NAME}") | ||
| fi |
There was a problem hiding this comment.
When testing this I realized you also need to check if repo is forked from the template or if the repo that is forked from is generated from the template...for example my repo partner.ubq.fi is forked from ubiquity/partner.ubq.fi which is generated from ts-template.
Honestly it might be easier to just check if it has related history with git merge-base
There was a problem hiding this comment.
If a repository is generated from a template, the history won't be persevered, but it starts with a fresh history. That's why git merge-base won't work. But we still can use it to check if a repo is forked from the template or not.
To check if a repo is forked from a repo that is generated from the template, it can get quite complicated. Do we really need that in our use case?
There was a problem hiding this comment.
Made some changes.
QA: https://github.com/ariesgun/.github/actions/runs/14281565726
One thing I notice is that it tries to sync ubiquity/research because it shares some commits with ts-template. Don't think there is anything I can do here except fixing ubiquity/research itself.
Tried it with my forked repositories, here is the result
https://github.com/ariesgun/.github/actions/runs/14281557207
|
I also got this weird error: https://github.com/ubiquity-whilefoo/.github/actions/runs/14294792370/job/40060570493#step:4:108 |
I couldn't reproduce the issue. Did you remove your repo |
|
Oh it seems it's because it's a private repo |
I see. I added a check to skip the repo if it is private |
There was a problem hiding this comment.
https://github.com/ubiquity-whilefoo/permit-generation/pull/1/files
It might be because I'm using o4-mini but it puts ``` backticks in the file so maybe try adding in the prompt:
You must output in raw format that is suitable to write to a file, without any backticks or similar delimiters
Resolves ubiquity/ts-template#61
I only tried with 2 repositories. Here's are the results:
https://github.com/ariesgun/work.ubq.fi/pull/8
https://github.com/ariesgun/safe.ubq.fi/pull/2