Skip to content

Comments

Automatic sync#122

Merged
whilefoo merged 85 commits intoubiquity:mainfrom
ariesgun:automatic-sync
Apr 10, 2025
Merged

Automatic sync#122
whilefoo merged 85 commits intoubiquity:mainfrom
ariesgun:automatic-sync

Conversation

@ariesgun
Copy link
Contributor

@ariesgun ariesgun commented Mar 2, 2025

@ubiquity-os ubiquity-os bot marked this pull request as draft March 2, 2025 21:01
@ubiquity-os
Copy link

ubiquity-os bot commented Mar 2, 2025

! You need to link an issue before converting the pull request to ready for review.

@ariesgun ariesgun marked this pull request as ready for review March 2, 2025 21:02
@ubiquity-os ubiquity-os bot marked this pull request as draft March 2, 2025 21:03
ubiquity-os[bot]
ubiquity-os bot previously requested changes Mar 2, 2025
Copy link

@ubiquity-os ubiquity-os bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request does not address the specified task of analyzing GitCoin data and other grant platforms to understand the profit ratios between bounties and grants. The PR instead adds template synchronization functionality. Please provide analysis of grant platform data, revenue/profit metrics, and comparative analysis between bounties and grants as specified in the issue.

Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Don't use Python. We use typescript everywhere and never use Python or other languages in our stack.
  2. Use OpenRouter not anthropic directly.

@0x4007
Copy link
Member

0x4007 commented Mar 12, 2025

There's a part of me that thinks we should break my requests off to a separate task because I reviewed it so late.

@0x4007
Copy link
Member

0x4007 commented Mar 12, 2025

Also the linter definitely must not be working because your file naming is wrong. Kebab case only.

@gentlementlegen
Copy link
Member

I don't think there is any sort of linter here, this is not a typescript project.

@ariesgun
Copy link
Contributor Author

ariesgun commented Apr 4, 2025

Comment on lines 68 to 72
REPO_INFO=$(gh api "/repos/${repository}")
if [[ "$(echo "$REPO_INFO" | jq -r '.template_repository.full_name')" == "${TEMPLATE_REPO}" ]]; then
REPO_NAME=$(echo "$REPO_INFO" | jq -rc '.full_name')
ALL_REPOSITORIES+=("${REPO_NAME}")
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing this I realized you also need to check if repo is forked from the template or if the repo that is forked from is generated from the template...for example my repo partner.ubq.fi is forked from ubiquity/partner.ubq.fi which is generated from ts-template.
Honestly it might be easier to just check if it has related history with git merge-base

Copy link
Contributor Author

@ariesgun ariesgun Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a repository is generated from a template, the history won't be persevered, but it starts with a fresh history. That's why git merge-base won't work. But we still can use it to check if a repo is forked from the template or not.

To check if a repo is forked from a repo that is generated from the template, it can get quite complicated. Do we really need that in our use case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes.

QA: https://github.com/ariesgun/.github/actions/runs/14281565726
One thing I notice is that it tries to sync ubiquity/research because it shares some commits with ts-template. Don't think there is anything I can do here except fixing ubiquity/research itself.

Tried it with my forked repositories, here is the result
https://github.com/ariesgun/.github/actions/runs/14281557207

@ariesgun ariesgun requested a review from whilefoo April 5, 2025 11:47
@whilefoo
Copy link
Contributor

whilefoo commented Apr 6, 2025

I also got this weird error: https://github.com/ubiquity-whilefoo/.github/actions/runs/14294792370/job/40060570493#step:4:108
Maybe an invalid URL or something like that?

@ariesgun
Copy link
Contributor Author

ariesgun commented Apr 6, 2025

I also got this weird error: https://github.com/ubiquity-whilefoo/.github/actions/runs/14294792370/job/40060570493#step:4:108 Maybe an invalid URL or something like that?

I couldn't reproduce the issue. Did you remove your repo comment-incentives?
https://github.com/ariesgun/.github/actions/runs/14295820954/job/40062838767

@whilefoo
Copy link
Contributor

whilefoo commented Apr 6, 2025

Oh it seems it's because it's a private repo

@ariesgun
Copy link
Contributor Author

ariesgun commented Apr 6, 2025

Oh it seems it's because it's a private repo

I see. I added a check to skip the repo if it is private

@ariesgun ariesgun requested a review from whilefoo April 6, 2025 20:15
Copy link
Contributor

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ubiquity-whilefoo/permit-generation/pull/1/files
It might be because I'm using o4-mini but it puts ``` backticks in the file so maybe try adding in the prompt:
You must output in raw format that is suitable to write to a file, without any backticks or similar delimiters

@ariesgun ariesgun requested a review from whilefoo April 8, 2025 21:33
Copy link
Contributor

@whilefoo whilefoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whilefoo whilefoo marked this pull request as ready for review April 10, 2025 15:36
@whilefoo whilefoo merged commit 12609d2 into ubiquity:main Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic sync v2

4 participants