fix: align deploy workflow with manifest metadata extraction#60
Conversation
…o codex/fix/manifest-build
📝 WalkthroughWalkthroughThe PR updates the plugin template configuration across three files: the GitHub Actions workflow now excludes specific events from plugin execution; manifest.json is updated with plugin-specific metadata including name, description, event listeners configuration, and a skipBotEvents flag; and package.json dependency versions are bumped with reorganization between regular and development dependencies. Possibly related issues
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d4f93811f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| treatAsEsm: true | ||
| sourcemap: true | ||
| pluginEntry: "${{ github.workspace }}/src/action.ts" | ||
| excludeSupportedEvents: "issue_comment.created,pull_request_review_comment.created" |
There was a problem hiding this comment.
Stop excluding every supported event from metadata
This excludes both events the plugin declares and handles (src/types/context.ts:10, src/index.ts:11-15), which is why this commit’s generated manifest now has "ubiquity:listeners": []. In environments where dispatch is driven by manifest listeners, that leaves the plugin with no subscribed events and prevents /hello handlers from being invoked.
Useful? React with 👍 / 👎.
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Review | Specification | 1 | 2.555 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
This updates the deploy workflow to use the issue-27 manifest me… | 2.04content:
content:
p:
score: 0
elementCount: 2
a:
score: 1
elementCount: 1
result: 1
regex:
wordCount: 20
wordValue: 0.1
result: 1.04
authorship: 1
| Relevance: 0.5 Readability: 44.4 | 1 | 2.555 |
This updates the deploy workflow to use the issue-27 manifest metadata flow and explicit event exclusions where required.
Resolves ubiquity-os/action-deploy-plugin#27