Skip to content

Comments

fix: align deploy workflow with manifest metadata extraction#60

Merged
gentlementlegen merged 9 commits intoubiquity-os:developmentfrom
gentlementlegen:codex/fix/manifest-build
Feb 11, 2026
Merged

fix: align deploy workflow with manifest metadata extraction#60
gentlementlegen merged 9 commits intoubiquity-os:developmentfrom
gentlementlegen:codex/fix/manifest-build

Conversation

@gentlementlegen
Copy link
Member

This updates the deploy workflow to use the issue-27 manifest metadata flow and explicit event exclusions where required.

Resolves ubiquity-os/action-deploy-plugin#27

@gentlementlegen gentlementlegen marked this pull request as ready for review February 11, 2026 12:48
@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

📝 Walkthrough

Walkthrough

The PR updates the plugin template configuration across three files: the GitHub Actions workflow now excludes specific events from plugin execution; manifest.json is updated with plugin-specific metadata including name, description, event listeners configuration, and a skipBotEvents flag; and package.json dependency versions are bumped with reorganization between regular and development dependencies.

Possibly related issues

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive Changes partially address issue #27: manifest.name/description updated from package.json, skipBotEvents added to manifest, ubiquity:listeners array added. However, commands generation and strict validation mentioned in criteria are not evidenced. Verify that manifest.commands generation from code is implemented, ubiquity:listeners is populated from typed sources, and CI validation prevents manual edits.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Title accurately describes the main change: aligning the deploy workflow with manifest metadata extraction as outlined in issue #27.
Description check ✅ Passed Description references the correct issue using the required keyword 'Resolves' and explains the workflow update, but links to external action repo instead of internal issue.
Out of Scope Changes check ✅ Passed Changes align with issue #27 scope: workflow event exclusions, manifest metadata updates, dependency bumps, and package.json description sync are all directly related to manifest generation objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d4f93811f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

treatAsEsm: true
sourcemap: true
pluginEntry: "${{ github.workspace }}/src/action.ts"
excludeSupportedEvents: "issue_comment.created,pull_request_review_comment.created"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop excluding every supported event from metadata

This excludes both events the plugin declares and handles (src/types/context.ts:10, src/index.ts:11-15), which is why this commit’s generated manifest now has "ubiquity:listeners": []. In environments where dispatch is driven by manifest listeners, that leaves the plugin with no subscribed events and prevents /hello handlers from being invoked.

Useful? React with 👍 / 👎.

@gentlementlegen gentlementlegen merged commit c489871 into ubiquity-os:development Feb 11, 2026
3 checks passed
@gentlementlegen gentlementlegen deleted the codex/fix/manifest-build branch February 11, 2026 12:56
@ubiquity-os-beta
Copy link
Contributor

ubiquity-os-beta bot commented Feb 11, 2026

 [ 2.555 UUSD ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
ReviewSpecification12.555
Conversation Incentives
CommentFormattingRelevancePriorityReward
This updates the deploy workflow to use the issue-27 manifest me…
2.04
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 1
      elementCount: 1
  result: 1
regex:
  wordCount: 20
  wordValue: 0.1
  result: 1.04
authorship: 1
Relevance: 0.5
Readability: 44.4
12.555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate manifest metadata from code/package.json (commands, listeners, skipBotEvents, name, description)

1 participant