Skip to content

Comments

Knip: globs for config.project#59

Merged
gentlementlegen merged 4 commits intoubiquity-os:developmentfrom
ubq-testing:development
Nov 30, 2025
Merged

Knip: globs for config.project#59
gentlementlegen merged 4 commits intoubiquity-os:developmentfrom
ubq-testing:development

Conversation

@Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Nov 21, 2025

Resolves #51
Relates to ubiquity-os/plugin-sdk#139

deps:

  • @ubiquity-os/plugin-sdk@latest
  • @ubiquity-os/ubiquity-os-logger@latest

tsconfig:

  • moduleResolution: bundler

Knip:

  • globs work better
  • removed redundant src/worker.ts as advised by knip from entry
  • removed redundant comment
  • removed husky from ignored as advised by knip

Eslint:

  • added a top-level ignore for @ubiquity-os/empty-string-checker in issue-template.ts

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 21, 2025

@gentlementlegen I had to resolved these in my recent fork of the template and is related to ubiquity-os/plugin-sdk#139 sort of, so thought I'd jump on it.

Edit: realized that there was an open issue to fix the knip config after the fact lol

@ubiquity-os-beta ubiquity-os-beta bot closed this Nov 21, 2025
@ubiquity-os-beta
Copy link
Contributor

Warning

You may not start the task because the issue requires a price label. Please ask a maintainer to add pricing.

This task does not reflect a business priority at the moment.
You may start tasks with one of the following labels: Priority: 0 (Regression), Priority: 1 (Normal), Priority: 2 (Medium), Priority: 3 (High), Priority: 4 (Urgent), Priority: 5 (Emergency)

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 22, 2025

Updated for whenever the PR gets re-opened, cheers dude

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the plugin template's configuration and dependencies to align with the latest @ubiquity-os/plugin-sdk updates. The changes focus on improving TypeScript module resolution, updating Knip configuration to use glob patterns, and adding proper type support for the custom Octokit instance.

  • Updated dependencies to latest versions (@ubiquity-os/plugin-sdk@3.4.2, @ubiquity-os/ubiquity-os-logger@1.4.0)
  • Modernized TypeScript configuration with moduleResolution: bundler
  • Improved Knip configuration with glob patterns for better file matching

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
tsconfig.json Changed moduleResolution from Node to bundler for modern bundler compatibility
src/types/context.ts Added customOctokit type to Context for proper Octokit instance typing
bun.lock Updated dependency versions for plugin-sdk, logger, and Octokit packages
.github/knip.ts Replaced directory paths with glob patterns, removed redundant src/worker.ts entry and husky from ignored dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gentlementlegen
Copy link
Member

Seems fine, I guess we should update our packages within another tasks, many of them are deprecated.

@gentlementlegen gentlementlegen merged commit 9906dd6 into ubiquity-os:development Nov 30, 2025
3 checks passed
@ubiquity-os-beta
Copy link
Contributor

ubiquity-os-beta bot commented Nov 30, 2025

 [ 9 UUSD ] 

@Keyrxng
⚠️ Your rewards have been limited to the task price of 9 UUSD.
Contributions Overview
ViewContributionCountReward
IssueTask Simplification10.01
ReviewSpecification110.69
ReviewComment20
Simplification Details for #59
FilenameRewardAdditionsDeletions
.github/knip.ts0.0134
Conversation Incentives
CommentFormattingRelevancePriorityReward
Resolves [https://github.com/ubiquity-os/plugin-template/issues/…
4.18
content:
  content:
    p:
      score: 0
      elementCount: 5
    ul:
      score: 0
      elementCount: 4
    li:
      score: 0.1
      elementCount: 8
    a:
      score: 1
      elementCount: 2
  result: 2.8
regex:
  wordCount: 32
  wordValue: 0.1
  result: 1.38
authorship: 1
Relevance: 1
Readability: 52.9
110.69
@gentlementlegen I had to resolved these in my recent fork of th…
1
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 1
      elementCount: 1
  result: 1
regex:
  wordCount: 43
  wordValue: 0
  result: 0
authorship: 1
Relevance: 0
Readability: 72.1
10
Updated for whenever the PR gets re-opened, cheers dude
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 10
  wordValue: 0
  result: 0
authorship: 1
Relevance: 0
Readability: 78.2
10

 [ 0.17 UUSD ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
ReviewCode Review30.17
ReviewComment10
Review Details for #59#issue-3034880374
ChangesPriorityReward
+7 -510.12
+0 -010
+1 -410.05
Conversation Incentives
CommentFormattingRelevancePriorityReward
Seems fine, I guess we should update our packages within another…
0.94
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 17
  wordValue: 0.1
  result: 0.94
authorship: 1
Relevance: 0
Readability: 65.2
10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Knip configuration

3 participants