Knip: globs for config.project#59
Conversation
|
@gentlementlegen I had to resolved these in my recent fork of the template and is related to ubiquity-os/plugin-sdk#139 sort of, so thought I'd jump on it. Edit: realized that there was an open issue to fix the knip config after the fact lol |
|
Warning You may not start the task because the issue requires a price label. Please ask a maintainer to add pricing. This task does not reflect a business priority at the moment. |
…ger dependencies to specific versions
|
Updated for whenever the PR gets re-opened, cheers dude |
There was a problem hiding this comment.
Pull request overview
This PR modernizes the plugin template's configuration and dependencies to align with the latest @ubiquity-os/plugin-sdk updates. The changes focus on improving TypeScript module resolution, updating Knip configuration to use glob patterns, and adding proper type support for the custom Octokit instance.
- Updated dependencies to latest versions (
@ubiquity-os/plugin-sdk@3.4.2,@ubiquity-os/ubiquity-os-logger@1.4.0) - Modernized TypeScript configuration with
moduleResolution: bundler - Improved Knip configuration with glob patterns for better file matching
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.json | Changed moduleResolution from Node to bundler for modern bundler compatibility |
| src/types/context.ts | Added customOctokit type to Context for proper Octokit instance typing |
| bun.lock | Updated dependency versions for plugin-sdk, logger, and Octokit packages |
| .github/knip.ts | Replaced directory paths with glob patterns, removed redundant src/worker.ts entry and husky from ignored dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Seems fine, I guess we should update our packages within another tasks, many of them are deprecated. |
|
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Task Simplification | 1 | 0.01 |
| Review | Specification | 1 | 10.69 |
| Review | Comment | 2 | 0 |
Simplification Details for #59
| Filename | Reward | Additions | Deletions |
|---|---|---|---|
| .github/knip.ts | 0.01 | 3 | 4 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
Resolves [https://github.com/ubiquity-os/plugin-template/issues/… | 4.18content:
content:
p:
score: 0
elementCount: 5
ul:
score: 0
elementCount: 4
li:
score: 0.1
elementCount: 8
a:
score: 1
elementCount: 2
result: 2.8
regex:
wordCount: 32
wordValue: 0.1
result: 1.38
authorship: 1
| Relevance: 1 Readability: 52.9 | 1 | 10.69 |
@gentlementlegen I had to resolved these in my recent fork of th… | 1content:
content:
p:
score: 0
elementCount: 2
a:
score: 1
elementCount: 1
result: 1
regex:
wordCount: 43
wordValue: 0
result: 0
authorship: 1
| Relevance: 0 Readability: 72.1 | 1 | 0 |
Updated for whenever the PR gets re-opened, cheers dude | 0content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 10
wordValue: 0
result: 0
authorship: 1
| Relevance: 0 Readability: 78.2 | 1 | 0 |
[ 0.17 UUSD ]
@gentlementlegen
Contributions Overview
| View | Contribution | Count | Reward |
|---|---|---|---|
| Review | Code Review | 3 | 0.17 |
| Review | Comment | 1 | 0 |
Review Details for #59#issue-3034880374
| Changes | Priority | Reward |
|---|---|---|
| +7 -5 | 1 | 0.12 |
| +0 -0 | 1 | 0 |
| +1 -4 | 1 | 0.05 |
Conversation Incentives
| Comment | Formatting | Relevance | Priority | Reward |
|---|---|---|---|---|
Seems fine, I guess we should update our packages within another… | 0.94content:
content:
p:
score: 0
elementCount: 1
result: 0
regex:
wordCount: 17
wordValue: 0.1
result: 0.94
authorship: 1
| Relevance: 0 Readability: 65.2 | 1 | 0 |
Resolves #51
Relates to ubiquity-os/plugin-sdk#139
deps:
@ubiquity-os/plugin-sdk@latest@ubiquity-os/ubiquity-os-logger@latesttsconfig:
moduleResolution: bundlerKnip:
src/worker.tsas advised byknipfromentryhuskyfrom ignored as advised byknipEslint:
@ubiquity-os/empty-string-checkerinissue-template.ts