Fse issue 360 2

[ubikfsabbe]

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• I have updated the documentation accordingly.

[FSchumacher]

Thanks for the work!
Some remarks.

• The patch contains a lot of re-formatting, that makes it unnecessary hard to see the real changes (I am in favour of (some of ) the changes, but perhaps not in this patch :)
• Have you tried to use a LinkedBlockingQueue, an ArrayBlockingQueue or some other classes provided by commons-collections4?

[ubikloadpack]

Hi Felix, Thanks for feedback. Regarding formatting we’ll fix it Regarding your question, see this for explanation of this choice https://itnext.io/understanding-the-lmax-disruptor-caaaa2721496 Note that log4j2 from Apache uses this library also. Regards

…

On Saturday, June 20, 2020, Felix Schumacher ***@***.***> wrote: Thanks for the work! Some remarks. - The patch contains a lot of re-formatting, that makes it unnecessary hard to see the real changes (I am in favour of (some of ) the changes, but perhaps not in this patch :) - Have you tried to use a LinkedBlockingQueue, an ArrayBlockingQueue or some other classes provided by commons-collections4? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADSIZY2EIWOFIWBQGJHZI7DRXRVQBANCNFSM4OC3PGCQ> .

-- Cordialement. Philippe Mouawad.