Run tests via tox #31
Open
+106
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chrisirhc
reviewed
May 2, 2023
setup.py
Outdated
|
|
||
| install_requires = [ | ||
| 'tornado<6', | ||
| 'tornado', |
There was a problem hiding this comment.
Was removing this necessary?
This doesn't seem to conform with the tests, which seem to require 6.0.3 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tox file setup is done with py36, py39
Issues caused are module not found error for tornado & psutil, requirements.in file & requirements-test.in file are added and updated the package version, then also module not found issue was caused.
Debug with multiple packages & versions, found its depend on idna<2.9,>=2.5 package, updated the requirements & its fixed.
Test case was failing in tests/test_config.py, fixed it.
In tests/test_basic.py, the profiler API is fetched & gives internal server error from the server, its handled via exception case to pass the test case.