Symfony Migration - Lint fixes #2161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fix the following errors: ``` 0 old problems 1 new problem (0 errors) (1 warning) /home/runner/work/xdmod/xdmod/libraries/security.php 53:1 NEW ERROR The closing brace for the class must go on the next line after the body 62:9 NEW ERROR There must be a comment when fall-through is intentional in a non-empty case body ``` from this run: https://github.com/ubccr/xdmod/actions/runs/21184903629/job/60936693257?pr=2145
These changes fix the following errors: ``` /home/runner/work/xdmod/xdmod/tests/integration/lib/BaseTest.php 904:1 NEW ERROR The closing brace for the class must go on the next line after the body 0 old problems 1 new problem (1 error) (0 warnings) ``` Which is from this run: https://github.com/ubccr/xdmod/actions/runs/21184903629/job/60936693257?pr=2145
These changes fix the following errors: ``` /home/runner/work/xdmod/xdmod/tests/integration/lib/Rest/WarehouseExportControllerProviderTest.php 194:29 NEW ERROR Expected 1 space after FUNCTION keyword; 0 found 215:78 NEW ERROR Expected 1 space after USE keyword; found 0 0 old problems 2 new problems (2 errors) (0 warnings) ``` from this run: https://github.com/ubccr/xdmod/actions/runs/21184903629/job/60936693257?pr=2145
These changes fix the following errors / warnings: ``` 1120:5 NEW ERROR 'logoutCallback' is assigned a value but never used. (no-unused-vars) 1132:13 NEW WARNING Expected method shorthand. (object-shorthand) 1133:17 NEW ERROR Unexpected use of 'location'. (no-restricted-globals) 1133:33 NEW ERROR Strings must use singlequote. (quotes) 1139:42 NEW ERROR Missing space before function parentheses. (space-before-function-paren) 1142:14 NEW WARNING Unexpected string concatenation. (prefer-template) 1142:18 NEW ERROR Unexpected string concatenation of literals. (no-useless-concat) 1144:9 NEW WARNING Expected method shorthand. (object-shorthand) 1145:13 NEW ERROR Unexpected use of 'location'. (no-restricted-globals) 1148:2 NEW ERROR Missing semicolon. (semi) 1237:48 NEW WARNING Unexpected string concatenation. (prefer-template) 1404:54 NEW WARNING Unexpected string concatenation. (prefer-template) ``` From the following run: https://github.com/ubccr/xdmod/actions/runs/21184903629/job/60936693257?pr=2145
These changes fix the following errors: ``` 24:11 NEW WARNING Usage of ELSE IF is discouraged; use ELSEIF instead ```
These changes are for: ``` 118:13 NEW ERROR Line indented incorrectly; expected 8 spaces, found 12 120:13 NEW ERROR Line indented incorrectly; expected 8 spaces, found 12 ```
These changes fix the following: ``` 211:5 NEW ERROR The closing parenthesis and the opening brace of a multi-line function declaration must be on the same line 982:15 NEW WARNING Usage of ELSE IF is discouraged; use ELSEIF instead ```
This fixes the following error: ``` 14:1 NEW WARNING This comment is 56% valid code; is this commented out code? ```
These changes fix the following errors: ``` 302:13 NEW WARNING Unexpected var, use let or const instead. (no-var) ``` Which can be found here: https://github.com/ubccr/xdmod/actions/runs/21184903629/job/60936693257?pr=2145
ryanrath
added
Category:General
Contributor
Author
|
NOTE: the linter check is failing because of the spacing changes that the linter wanted failing our "extra tests" |
ryanrath
requested review from
aaronweeden,
connersaeli,
eiffel777,
jpwhite4 and
rvtovar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just changes to new / updated code that was failing the lint tests.
Motivation and Context
Because new / updated code should comply with our linting rules.
Tests performed
Checklist: