Fixing notices/warnings for PHP 5.6#172
Open
BrendonKoz wants to merge 3 commits intoualibraries:masterfrom
BrendonKoz:master
Open
Fixing notices/warnings for PHP 5.6#172BrendonKoz wants to merge 3 commits intoualibraries:masterfrom BrendonKoz:master
BrendonKoz wants to merge 3 commits intoualibraries:masterfrom
BrendonKoz:master
Conversation
Fixed PHP notice level errors Fixed compatibility errors up to PHP 5.6 Updated Tags plugin to current version
Fixed all errors that were being displayed with regard to PHP v5.6. Cleaned up some syntax inconsistencies in various files.
Fixing PHP 5.6 errors
Member
|
Thanks so much, @BrendonKoz! We'll take a look. |
Author
|
There are a lot of unnecessary text changes that have been made due to my editor (sorry). I just noticed that changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed any/all warnings and notices that I discovered running the current master under PHP 5.6 (with CakePHP debug set to 2).
This is just the start of the effort to properly upgrade compatibility to Cake PHP v2.8 (minimum) for PHP7 compatibility.