feat: add configurable logging#12
Merged
jasonbosco merged 4 commits intotypesense:masterfrom Sep 24, 2025
Merged
Conversation
jasonbosco
approved these changes
Sep 24, 2025
Member
|
This is now available in v1.0.0.rc3 |
|
It's odd for a gem to change the Logger.level is something that should be configured by the user on his own application not inside a gem. This PR leads to a confusing pattners as @stephannv pointed out on his #11 (comment) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Expand on #11 to include a configurable log level parameter when configuring the gem, instead of removing loggin outright. Default log level to warn.
closes #2
PR Checklist