fix(api): improve error handling for invalid JSON responses#84
Merged
kishorenc merged 2 commits intotypesense:masterfrom Apr 28, 2025
Merged
fix(api): improve error handling for invalid JSON responses#84kishorenc merged 2 commits intotypesense:masterfrom
kishorenc merged 2 commits intotypesense:masterfrom
Conversation
- enhance `_get_error_message` to handle JSON decode errors - add detailed error message including the invalid response text - add tests covering valid JSON, invalid JSON, and non-JSON responses
Contributor
Author
kishorenc
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Closes #82
_get_error_messageto handle JSON decode errorsPR Checklist