Conversation
- Create `MetricsResponse` types to handle API responses - Add support for retrieving system metrics (CPU, memory, disk, network) - Add support for Typesense-specific memory metrics - Ensure compatibility with Python 3.11+ and earlier versions
- Add `Metrics` class with API integration - Create method to retrieve system and Typesense metrics - Define endpoint path for metrics retrieval - Connect with existing `MetricsResponse` type
- Import `Metrics` class in `client.py` - Add `metrics` attribute to `Client` class documentation - Initialize `metrics` instance in `Client` constructor - Update module documentation to reference metrics dependency
- Create `metrics_fixtures.py` with pytest fixture - Set up fixture to return a `Metrics` object with actual API call - Configure fixture with function scope for isolated testing
- Create `metrics_test.py` to test the `Metrics` class - Implement test for the `retrieve()` method - Verify all expected system metrics fields are p
kishorenc
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Add metrics API support with tests and types
PR Checklist