chore: bump vitest and update nvmrc#320
Merged
jasonbosco merged 4 commits intotypesense:masterfrom Nov 18, 2025
Merged
Conversation
jasonbosco
requested changes
Oct 30, 2025
.nvmrc
Outdated
| @@ -1 +1 @@ | |||
| 18 No newline at end of file | |||
| lts/* No newline at end of file | |||
Member
There was a problem hiding this comment.
@tharropoulos I'd prefer that we be explicit about the node version we're using, so as to not accidentally end up dropping support for an older version without intending to in the future. Because we also need to document any Node compatibility changes in the changelogs.
Collaborator
Author
There was a problem hiding this comment.
Node 18 has been in EOL since Apr 30. Using that version already breaks dependencies, as most require at least 20-22. I'll change it to 22
tharropoulos
force-pushed
the
bump-deps
branch
from
5fa09a3 to
ff6b8e7
Compare
Collaborator
Author
|
@jasonbosco Can we merge this so the other builds aren't failing on CI? |
jasonbosco
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
PR Checklist