Artemis: Refactor PrimeFactors method to use ArrayList instead of Vector #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
PrimeFactorsmethod to usejava.util.ArrayListinstead ofjava.util.Vectorfor storing prime factors. The change includes an update to the method's return type and the internal collection instantiation. Additionally, the JavaDoc comments have been revised to reflect the new collection type used. This refactor enhances performance by eliminating the overhead associated withVector's default synchronization, making the method more efficient in single-threaded scenarios. It also aligns the code with modern Java practices by opting forArrayList, which is generally lighter and faster. Note that the logic for calculating prime factors remains unchanged; only the collection type has been modified. Users of the method will need to adjust their code to accommodate the new return type.