Artemis: Optimize Prime Checking and Factorization Logic #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant optimizations to the
IsPrimeandPrimeFactorsmethods within thePrimesclass. Key changes include:Prime Checking Optimization: The loop condition in the
IsPrimemethod has been modified fromi < ntoi * i <= n, reducing the number of iterations needed to check for primality. Additionally, the redundant check&& i != nhas been removed for clarity.Enhanced Prime Factorization: The
PrimeFactorsmethod now uses a similar loop condition (i * i <= n) for efficiency. Awhileloop has been implemented to handle repeated prime factors, ensuring that each factor is fully divided out before moving on. An extra check is added to includenas a prime factor if it remains greater than 1 after factorization.These changes significantly improve the performance of both algorithms, particularly for larger integers, while also enhancing code readability.