Artemis: Refactor Primes Class for Enhanced Efficiency and Code Quality #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant optimizations and improvements to the Primes class. Key changes include:
Imports Updated: Switched from
java.util.Vectortojava.util.ArrayListfor better performance and flexibility.Optimized Prime Checking: The
IsPrimemethod now checks for primality up to the square root ofn, reducing unnecessary iterations and removing redundant checks.Adjusted SumPrimes Method: The loop in
SumPrimesnow starts at2, and the sum operation has been simplified for clarity.Enhanced PrimeFactors Method: Updated to return an
ArrayList<Integer>and optimized the logic to find prime factors using a while loop, including a check fornitself as a prime factor if applicable.These changes collectively enhance the efficiency of prime checking and factorization processes, reduce time complexity for larger inputs, and improve code readability and maintainability.