Open
Conversation
turecekt
requested changes
Feb 6, 2024
Owner
turecekt
left a comment
turecekt
left a comment
There was a problem hiding this comment.
- Upravit funkcionalitu tak, aby se ve funkci koch nevolaly funkce left a forward viz code review. Následně by mohl měly projít všechny unit testy. Je otázka, jestli bude postačovat pokrytí kódu testy.
- Aby prošel flake, musí se buď docstringy nadefinovat i v celém souboru main_test.py nebo můžete testy přepsat jako doctesty do docstringů.
- Upravit docstringy u funkcí pro přehlednější dokumentaci viz: https://github.com/turecekt/vs_project/blob/master/example.py
- Chyby je možné po každém odjetí do repozitáře sledovat v testech kontinuální integrace zde: https://github.com/m-korenek/KochSnowflake/actions
- Po úspěšném vygenerování dokumentace na konci testů upravit website url na hlavní stránce repa na url s vygenerovanou dokumentací.
main.py
Outdated
| if order > 0: | ||
| for t in [60, -120, 60, 0]: | ||
| koch(a / 3, order - 1, instr) | ||
| left(t) |
main.py
Outdated
| left(t) | ||
| instr.append(('left', t)) | ||
| else: | ||
| forward(a) |
main.py
Outdated
| # Three Koch curves | ||
| instruction = [] | ||
| for i in range(3): | ||
| koch(size, iteration) |
Owner
There was a problem hiding this comment.
Zde iterovat nad vráceným polem a v každé iteraci dle hodnot volat funkci left nebo forward včetně parametru.
turecekt
requested changes
Feb 10, 2024
Owner
turecekt
left a comment
turecekt
left a comment
There was a problem hiding this comment.
Ještě drobnost:
- v nastavení v sekci Pages je nutné nastavit Build and Deployment Source na Github Actions, případně zvolit workflow z repozitáře, zde: https://github.com/m-korenek/KochSnowflake/settings/pages
- nasledně odjet do repozitáře nějakou minimlní změnu pro opětovné spuštění workflow a publikování dokumentace na github pages
- v sekci About na hlavní stránce repozitáře nastavte Website url na url Github Pages vašeho repozitáře (ze sekce Pages v Settings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Odevzdání projektu AK1VS
Autor: Michael Kořének - m_korenek
Zadání: Kochova křivka