Skip to content

feat: make properties of GraphDependency.xcframework mutable #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fortmarek merged 2 commits into from
Nov 13, 2025
Merged

feat: make properties of GraphDependency.xcframework mutable #380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
426a737
feat: make properties of GraphDependency.xcframework mutable
fortmarek Nov 13, 2025
d0eedde
Merge branch 'main' into feat/xcframework-dependency-variables
fortmarek Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 8 additions & 11 deletions Sources/XcodeGraph/Graph/GraphDependency.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,21 @@ import Path

public enum GraphDependency: Hashable, CustomStringConvertible, Comparable, Codable, Sendable {
public struct XCFramework: Hashable, CustomStringConvertible, Comparable, Codable, Sendable {
public let path: AbsolutePath
public let infoPlist: XCFrameworkInfoPlist
public let linking: BinaryLinking
public let mergeable: Bool
public let status: LinkingStatus
public let swiftModules: [AbsolutePath]
public let moduleMaps: [AbsolutePath]
public let expectedSignature: String?
public var path: AbsolutePath
public var infoPlist: XCFrameworkInfoPlist
public var linking: BinaryLinking
public var mergeable: Bool
public var status: LinkingStatus
public var swiftModules: [AbsolutePath]
public var moduleMaps: [AbsolutePath]
public var expectedSignature: String?

public init(
path: AbsolutePath,
infoPlist: XCFrameworkInfoPlist,
linking: BinaryLinking,
mergeable: Bool,
status: LinkingStatus,
macroPath _: AbsolutePath?,
swiftModules: [AbsolutePath],
moduleMaps: [AbsolutePath],
expectedSignature: String? = nil
Expand Down Expand Up @@ -327,7 +326,6 @@ public enum GraphDependency: Hashable, CustomStringConvertible, Comparable, Coda
linking: BinaryLinking = .dynamic,
mergeable: Bool = false,
status: LinkingStatus = .required,
macroPath: AbsolutePath? = nil,
swiftModules: [AbsolutePath] = [],
moduleMaps: [AbsolutePath] = []
) -> GraphDependency {
Expand All @@ -338,7 +336,6 @@ public enum GraphDependency: Hashable, CustomStringConvertible, Comparable, Coda
linking: linking,
mergeable: mergeable,
status: status,
macroPath: macroPath,
swiftModules: swiftModules,
moduleMaps: moduleMaps
)
Expand Down
1 change: 0 additions & 1 deletion Sources/XcodeGraphMapper/Mappers/Targets/TargetDependency+GraphMapping.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ extension TargetDependency {
linking: metadata.linking,
mergeable: metadata.mergeable,
status: status,
macroPath: metadata.macroPath,
swiftModules: metadata.swiftModules,
moduleMaps: metadata.moduleMaps,
expectedSignature: metadata.expectedSignature?.signatureString()
Expand Down