feat: add support for strictMemorySafety SwiftSetting and improve error handling #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or handling This commit adds two important improvements to PackageInfo decoding: 1. **Add strictMemorySafety support**: Adds the strictMemorySafety setting introduced in Swift Package Manager 6.2 (SE-0458). This setting enables strict memory safety checking and was causing decoding failures when packages used this new setting. 2. **Improve error handling**: Wraps legacy format decoding in a try-catch block with a custom SettingDecodingError that provides actionable diagnostics including: - Exact location in the JSON structure (coding path) - Which tool the setting was for - Available keys in the malformed setting - Helpful guidance about likely causes Changes: - Add strictMemorySafety case to SettingName enum - Add strictMemorySafety(String) case to Kind enum - Add SettingDecodingError with descriptive error messages - Handle strictMemorySafety in decoder switch statement - Handle strictMemorySafety in encoder switch statement This fixes decoding errors like: ``` keyNotFound(CodingKeys(stringValue: "name", intValue: nil), ...) ``` And replaces them with: ``` Failed to decode target build setting at 'targets.Index 3.settings.Index 0'. Expected either 'kind' (Xcode 14+ format) or 'name' (legacy format) key, but neither was found. Tool: swift Available keys: tool, condition, kind ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
dosubot
bot
added
the
size:M
waltflanagan
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
strictMemorySafetySwiftSetting introduced in Swift Package Manager 6.2 (SE-0458) and significantly improves error handling for malformed package settings.Problem
When using Swift 6.2 with packages that enable strict memory safety checking via
.strictMemorySafety(), Tuist was failing with cryptic decoding errors:This happened because:
strictMemorySafetysetting typeKinddecoder failed, it fell back to legacy formatChanges
1. Add
strictMemorySafetySupportstrictMemorySafetycase toSettingNameenumstrictMemorySafety(String)case toKindenumstrictMemorySafetyin switch statementstrictMemorySafetyin switch statement2. Improve Error Handling
Introduced
SettingDecodingErrorthat provides actionable diagnostics:Before:
After:
Testing
swift build(3.53s)strictMemorySafetyContext
strictMemorySafetysetting per SE-0458🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com