feat: Add support for buildable folder exceptions #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
requested review from
cschmatzler and
fortmarek
and removed request for
a team
dosubot
bot
added
size:M
| /// - path: The absolute path to the buildable folder. | ||
| /// - exceptions: The set of exceptions (such as excluded files or custom compiler flags) for the folder. | ||
| /// - resolvedFiles: The list of files resolved from the folder, each file optionally having compiler flags. | ||
| public init(path: AbsolutePath, exceptions: BuildableFolderExceptions, resolvedFiles: [BuildableFolderFile]) { |
There was a problem hiding this comment.
maybe it's possible to have a default init (as right now) and a convenience one with the new params? or make them optional with fallback values in the init? This would not beak all projects
Member
There was a problem hiding this comment.
this is not an interface you directly interact with in your Project.swift manifests if that's what you're worried about
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets' buildable folders support exceptions, which are a mechanism to:
This PR adds the data structure changes to add support for these features in our generated projects.