Skip to content

Conversation

@navtoj
Copy link
Contributor

@navtoj navtoj commented Aug 18, 2025

Resolves #262 1

Changed the access level of loadXCTestMetadata to public in the SystemFrameworkMetadataProviding extension to allow usage in cli/Sources/TuistCore/Graph/GraphLoader.swift

Footnotes

  1. https://github.com/tuist/tuist/issues/7973#issuecomment-3195917874

@navtoj navtoj marked this pull request as ready for review August 18, 2025 10:16
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 18, 2025
@navtoj navtoj changed the title Make SystemFrameworkMetadataProviding extension public feat: make SystemFrameworkMetadataProviding extension public Aug 18, 2025
@pepicrft
Copy link
Contributor

@navtoj could you run mise run lint-fix to fix the linting issues?

Copy link
Member

@fortmarek fortmarek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good after CI is green 👀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 18, 2025
@navtoj navtoj changed the title feat: make SystemFrameworkMetadataProviding extension public feat: make loadXCTestMetadata method public Aug 18, 2025
@navtoj
Copy link
Contributor Author

navtoj commented Aug 19, 2025

looks good after CI is green 👀

@fortmarek Looks like all checks pass now, okay to merge?

@fortmarek
Copy link
Member

Yes!

@fortmarek fortmarek merged commit eed1637 into tuist:main Aug 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SDKSource for XcodeKit

3 participants