-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Add Target.buildableFolders attribute #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f1ecbca
Add Target.buildableFolders attribute
pepicrft 37c2e3f
Update Sources/XcodeGraph/Models/BuildableFolder.swift
pepicrft 21afcd0
Use another conventional PR workflow
pepicrft 34d6005
Don't require scope
pepicrft e746ecb
Fix compilation of docs
pepicrft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,15 @@ | ||
| name: conventional-pr | ||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - master | ||
| types: | ||
| - opened | ||
| - edited | ||
| - synchronize | ||
| pull_request: {} | ||
|
|
||
| jobs: | ||
| lint-pr: | ||
| name: Lint PR | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| - uses: CondeNast/conventional-pull-request-action@v0.2.0 | ||
| - uses: amannn/action-semantic-pull-request@v5 | ||
| with: | ||
| requireScope: false | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import Path | ||
|
|
||
| /// A buildable folder maps to an PBXFileSystemSynchronizedRootGroup in Xcode projects. | ||
| /// Synchronized groups were introduced in Xcode 16 to reduce git conflicts by having a reference | ||
| /// to a folder whose content is "synchronized" by Xcode itself. Think of it as Xcode resolving | ||
| /// the globs. | ||
| public struct BuildableFolder: Sendable, Codable, Equatable, Hashable { | ||
| /// The absolute path to the buildable folder. | ||
| public var path: AbsolutePath | ||
|
|
||
| /// Creates an instance of buildable folder. | ||
| /// - Parameter path: Absolute path to the buildable folder. | ||
| public init(path: AbsolutePath) { | ||
| self.path = path | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you move this property below
sources?, it will be better when both are next to each other. Then as a user I don't have to jump around to see which files or folder are part of targetThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that
XcodeGraphis not the abstraction used inProject.swift. We have an extra layer that sits in-between.I don't have a strong preference here, but agree that in
ProjectDescription, it should be close tosourcesandresources.