-
Notifications
You must be signed in to change notification settings - Fork 39
feat: add default configuration name to the settings #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default configuration name to the settings #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new default configuration name to the settings model.
- Added an optional String property "defaultConfiguration" to the Settings struct.
- Updated the initializer and the "with" function to accommodate the new property.
|
Let's wait until this one is ready to merge this sone. Also, thoughts on the schema changes @fortmarek ? |
fortmarek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good here ✅
|
As the other PR is ready and to pass the CI this PR needs to be merged. |
|
Thanks again for the contribution! |
This is the counter PR for tuist/tuist#7577