Skip to content

feat: add the App Clip's URL to the Run action #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fortmarek merged 3 commits into from
Jun 30, 2025
Merged

feat: add the App Clip's URL to the Run action #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98516a2
feat: add the App Clip's URL to the Run action
ns-vasilev May 2, 2025
de8fd78
feat: change parsing of App Clips data from a string to a URL
ns-vasilev Jun 8, 2025
21e54c7
Update Sources/XcodeGraph/Models/RunAction.swift
fortmarek Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Sources/XcodeGraph/Models/RunAction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public struct RunAction: Equatable, Codable, Sendable {
public let metalOptions: MetalOptions?
public let expandVariableFromTarget: TargetReference?
public let launchStyle: LaunchStyle
public let appClipInvocationURL: URL?

// MARK: - Init

Expand All @@ -33,7 +34,8 @@ public struct RunAction: Equatable, Codable, Sendable {
diagnosticsOptions: SchemeDiagnosticsOptions,
metalOptions: MetalOptions? = nil,
expandVariableFromTarget: TargetReference? = nil,
launchStyle: LaunchStyle = .automatically
launchStyle: LaunchStyle = .automatically,
appClipInvocationURL: URL? = nil
) {
self.configurationName = configurationName
self.attachDebugger = attachDebugger
Expand All @@ -48,6 +50,7 @@ public struct RunAction: Equatable, Codable, Sendable {
self.metalOptions = metalOptions
self.expandVariableFromTarget = expandVariableFromTarget
self.launchStyle = launchStyle
self.appClipInvocationURL = appClipInvocationURL
}
}

Expand All @@ -72,7 +75,8 @@ public struct RunAction: Equatable, Codable, Sendable {
apiValidation: true
),
expandVariableFromTarget: TargetReference? = nil,
launchStyle: LaunchStyle = .automatically
launchStyle: LaunchStyle = .automatically,
appClipInvocationURL: URL? = nil
) -> RunAction {
RunAction(
configurationName: configurationName,
Expand All @@ -87,7 +91,8 @@ public struct RunAction: Equatable, Codable, Sendable {
diagnosticsOptions: diagnosticsOptions,
metalOptions: metalOptions,
expandVariableFromTarget: expandVariableFromTarget,
launchStyle: launchStyle
launchStyle: launchStyle,
appClipInvocationURL: appClipInvocationURL
)
}
}
Expand Down
3 changes: 2 additions & 1 deletion Sources/XcodeGraphMapper/Mappers/Schemes/XCSchemeMapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ struct XCSchemeMapper: SchemeMapping {
filePath: nil,
arguments: arguments,
options: RunActionOptions(),
diagnosticsOptions: diagnosticsOptions
diagnosticsOptions: diagnosticsOptions,
appClipInvocationURL: action.appClipInvocationURLString.flatMap { URL(string: $0) }
)
}

Expand Down
3 changes: 2 additions & 1 deletion Tests/XcodeGraphTests/Models/RunActionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ final class RunActionTests: XCTestCase {
diagnosticsOptions: SchemeDiagnosticsOptions(
mainThreadCheckerEnabled: true,
performanceAntipatternCheckerEnabled: true
)
),
appClipInvocationURL: URL(string: "https://app-clips-url.com/example")
)

// Then
Expand Down