Skip to content

Conversation

@alexmx
Copy link
Collaborator

@alexmx alexmx commented May 1, 2025

This PR implements the support for variable InfoPlist file paths for build settings that mirrors the existing API for setting variable entitlements file paths. The issue has been described in detail here: tuist/tuist#6727

This change is needed to unblock tuist/tuist#7404

@alexmx
Copy link
Collaborator Author

alexmx commented May 9, 2025

@pepicrft any chance you can take a look please?

Copy link
Contributor

@pepicrft pepicrft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexmx for contributing this one. I left a small comment.

@pepicrft pepicrft changed the title Add support for variable InfoPlist file paths eat: add support for defining Info.plist files using a variable May 12, 2025
@pepicrft pepicrft changed the title eat: add support for defining Info.plist files using a variable feat: add support for defining Info.plist files using a variable May 12, 2025
@alexmx
Copy link
Collaborator Author

alexmx commented May 20, 2025

@pepicrft any chance you can take a loot at this again please?

@pepicrft pepicrft merged commit f963c5f into tuist:main May 20, 2025
7 checks passed
@pepicrft
Copy link
Contributor

@all-contributors add @alexmx for code

@allcontributors
Copy link
Contributor

@pepicrft

I've put up a pull request to add @alexmx! 🎉

@pepicrft
Copy link
Contributor

@alexmx thanks a lot for this improvement. I made you a collaborator of the repository so that you can push your code contributions directly to this repository without having to work from forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants