refactor: migrate to xcodeproj 9 #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waltflanagan
force-pushed
the
waltflaagan/StronglyTypedBuildSettings
branch
from
7feb8e4 to
3b37cf5
Compare
waltflanagan
changed the title
waltflanagan
force-pushed
the
waltflaagan/StronglyTypedBuildSettings
branch
from
36fbb3c to
bb80553
Compare
waltflanagan
commented
Mar 16, 2025
| mergedBinaryType: mergedBinaryType, | ||
| mergeable: mergeable, | ||
| onDemandResourcesTags: onDemandResourcesTags, | ||
| metadata: metadata, |
Contributor
Author
There was a problem hiding this comment.
The items removed here do not map directly to properties in an XcodeProj file. Most of these parameters control Tuist specific behaviors like scheme generation or adding build settings. Since this mapper is reading already generated .pbxproj files the values there should be the source of truth and we should not reconstruct Tuist specific information from build settings.
waltflanagan
changed the title
dosubot
bot
added
the
size:L
fortmarek
approved these changes
Mar 17, 2025
Member
fortmarek
left a comment
fortmarek
left a comment
There was a problem hiding this comment.
Seeing how much the code has simplified with the new XcodeProj changes definitely suggests that the refactoring was worth it. Thanks a ton @waltflanagan. This is good to merge once the Package.swift is updated to use the 9.0.0 XcodeProj without using a fork.
waltflanagan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to what will be come the 9.0 release of
XcodeProjwhich introduces a strongly typed API around components of apbxprojthat used to be represented byAnyA side effect of this changes removes some inference of
Targetproperties from build settings. These properties manage Tuist specific behaviors and would never occur in an Xcode created project in normal circumstances.DO NOT MERGE without updating the
package.swiftreference oncexcodeprojis updated to 9.0,