fix: skip mapping aggregate targets #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
force-pushed
the
fix/aggregate-target
branch
from
8a27d73 to
9cd934e
Compare
pepicrft
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @KaiOelfke, mapping aggregate targets is failing as we're assuming they have some properties that only
PBXNativeTargets have, such as a list of supported destinations.Since
XcodeGraphdoesn't currently support aggregate targets, we will, for now, skip mapping these completely.I flagged an issue to eventually add support for these targets, so the conversion from XcodeProj to XcodeGraph is not lossy.