fix: duplicated values in build settings #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
force-pushed
the
fix/duplicated-settings-values
branch
from
5171e0c to
d241950
Compare
fortmarek
force-pushed
the
fix/duplicated-settings-values
branch
from
d241950 to
294a7de
Compare
fortmarek
force-pushed
the
fix/duplicated-settings-values
branch
from
294a7de to
8b05fa9
Compare
cschmatzler
approved these changes
Feb 20, 2025
pepicrft
approved these changes
Feb 20, 2025
fortmarek
added a commit
that referenced
this pull request
Feb 20, 2025
This reverts commit db41514.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When combining two settings values that are both arrays, we can easily introduce duplicate values. In extreme cases, this leads to thousands of duplicates, causing Xcode to freeze.