fix: mapping resource build phase with bundle targets #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
commented
Feb 19, 2025
Comment on lines
-337
to
-338
| /// Reads and parses a plist file into a `[String: Plist.Value]` dictionary. | ||
| private func readPlistAsDictionary( |
Member
Author
There was a problem hiding this comment.
for some reason, when mapping a generated Tuist.xcworkspace in tuist/tuist, this would always throw with the same error as we've seen in the past: tuist/tuist#7018
Since we don't strictly need the plist dictionary need, I decided to, at least for now, return a plain path reference instead of parsing the plist.
Member
Author
|
I'm more than happy to apply any comments in a follow-up PR, but since we want this for today's Tuist release, I'll go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is very similar to #110 but for resources. In a resources build phase, we can reference a target bundle that's in build products directory. In that case, instead of trying to resolve a full path, we should return either
.targetor.projectdependency.